From 810d92676ca738a91fc5af785000307d790835a2 Mon Sep 17 00:00:00 2001 From: Claude Date: Sat, 11 Apr 2026 19:50:59 +0000 Subject: [PATCH] fix: extend step 8 approval-bias carve-out to include infra files (step 3c), fix count MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Step 8 now explicitly exempts infrastructure file findings (step 3c) from the "bias toward APPROVE" guidance, preventing the original failure mode - Fix investigation summary: "Five" → "Six" structural gaps Co-Authored-By: Claude Opus 4.6 (1M context) --- ...stigation-685-reviewer-approved-destructive-compose.md | 2 +- formulas/review-pr.toml | 8 +++++--- 2 files changed, 6 insertions(+), 4 deletions(-) diff --git a/docs/investigation-685-reviewer-approved-destructive-compose.md b/docs/investigation-685-reviewer-approved-destructive-compose.md index 033688b..d8f9d2f 100644 --- a/docs/investigation-685-reviewer-approved-destructive-compose.md +++ b/docs/investigation-685-reviewer-approved-destructive-compose.md @@ -8,7 +8,7 @@ The reviewer agent approved PR #683 in ~1 minute without flagging that it contained a destructive rewrite of `docker-compose.yml` — dropping named -volumes, bind mounts, env vars, restart policy, and security options. Five +volumes, bind mounts, env vars, restart policy, and security options. Six structural gaps in the review pipeline allowed this to pass. ## Root causes diff --git a/formulas/review-pr.toml b/formulas/review-pr.toml index 67b6358..fe62a89 100644 --- a/formulas/review-pr.toml +++ b/formulas/review-pr.toml @@ -277,9 +277,11 @@ for actual problems (bugs, security issues, broken functionality, missing required behavior). Use DISCUSS sparingly. Note: The bias toward APPROVE applies to code correctness and style decisions. -It does NOT apply to documentation consistency (step 3b) or tech-debt filing -(step 7) — those are separate concerns that should be handled regardless of -the change's correctness. +It does NOT apply to documentation consistency (step 3b), infrastructure file +findings (step 3c), or tech-debt filing (step 7) — those are separate concerns +that should be handled regardless of the change's correctness. In particular, +dropped production configuration (volumes, bind mounts, env vars, restart +policy) is a blocking defect, not a style preference. ## 9. Output