From 2164991313ebb7cfa26b8ea866e6c98105d349fc Mon Sep 17 00:00:00 2001 From: Agent Date: Wed, 8 Apr 2026 10:13:35 +0000 Subject: [PATCH] =?UTF-8?q?fix:=20fix:=20review-pr.sh=20runs=20git=20comma?= =?UTF-8?q?nds=20before=20cd-ing=20to=20project=20repo=20=E2=80=94=20fails?= =?UTF-8?q?=20after=20image=20rebuild=20(#408)?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit --- review/review-pr.sh | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-) diff --git a/review/review-pr.sh b/review/review-pr.sh index 08ce653..a0e0ada 100755 --- a/review/review-pr.sh +++ b/review/review-pr.sh @@ -35,6 +35,10 @@ git -C "$FACTORY_ROOT" pull --ff-only origin main 2>/dev/null || true # --- Config --- PR_NUMBER="${1:?Usage: review-pr.sh [--force]}" + +# Change to project repo early — required before any git commands +# (factory root is not a git repo after image rebuild) +cd "${PROJECT_REPO_ROOT}" FORCE="${2:-}" API="${FORGE_API}" LOGFILE="${DISINTO_LOG_DIR}/review/review.log" @@ -163,12 +167,11 @@ DNOTE=""; [ "$FSIZE" -gt "$MAX_DIFF" ] && DNOTE=" (truncated from ${FSIZE} bytes # ============================================================================= # WORKTREE SETUP # ============================================================================= -cd "${PROJECT_REPO_ROOT}" git fetch "${FORGE_REMOTE}" "$PR_HEAD" 2>/dev/null || true if [ -d "$WORKTREE" ]; then cd "$WORKTREE"; git checkout --detach "$PR_SHA" 2>/dev/null || { - cd "${PROJECT_REPO_ROOT}"; worktree_cleanup "$WORKTREE" + worktree_cleanup "$WORKTREE" git worktree add "$WORKTREE" "$PR_SHA" --detach 2>/dev/null; } else git worktree add "$WORKTREE" "$PR_SHA" --detach 2>/dev/null