fix: fix: standardize logging across all agents — capture errors, log exit codes, consistent format (#367)

architect/architect-run.sh

@@ -48,13 +48,6 @@ WORKTREE="/tmp/${PROJECT_NAME}-architect-run"
 # shellcheck disable=SC2034  # consumed by agent-sdk.sh and env.sh log()
 LOG_AGENT="architect"
 
-# Override log() to append to architect-specific log file
-# shellcheck disable=SC2034
-log() {
-  local agent="${LOG_AGENT:-architect}"
-  printf '[%s] %s: %s\n' "$(date -u '+%Y-%m-%dT%H:%M:%SZ')" "$agent" "$*" >> "$LOG_FILE"
-}
-
 # ── Guards ────────────────────────────────────────────────────────────────
 check_active architect
 acquire_cron_lock "/tmp/architect-run.lock"

planner/planner-run.sh

@@ -47,13 +47,6 @@ WORKTREE="/tmp/${PROJECT_NAME}-planner-run"
 # shellcheck disable=SC2034  # consumed by agent-sdk.sh and env.sh log()
 LOG_AGENT="planner"
 
-# Override log() to append to planner-specific log file
-# shellcheck disable=SC2034
-log() {
-  local agent="${LOG_AGENT:-planner}"
-  printf '[%s] %s: %s\n' "$(date -u '+%Y-%m-%dT%H:%M:%SZ')" "$agent" "$*" >> "$LOG_FILE"
-}
-
 # ── Guards ────────────────────────────────────────────────────────────────
 check_active planner
 acquire_cron_lock "/tmp/planner-run.lock"

predictor/predictor-run.sh

@@ -48,13 +48,6 @@ WORKTREE="/tmp/${PROJECT_NAME}-predictor-run"
 # shellcheck disable=SC2034  # consumed by agent-sdk.sh and env.sh log()
 LOG_AGENT="predictor"
 
-# Override log() to append to predictor-specific log file
-# shellcheck disable=SC2034
-log() {
-  local agent="${LOG_AGENT:-predictor}"
-  printf '[%s] %s: %s\n' "$(date -u '+%Y-%m-%dT%H:%M:%SZ')" "$agent" "$*" >> "$LOG_FILE"
-}
-
 # ── Guards ────────────────────────────────────────────────────────────────
 check_active predictor
 acquire_cron_lock "/tmp/predictor-run.lock"

review/review-poll.sh

@@ -30,8 +30,7 @@ LOG_AGENT="review"
 # Override log() to append to review-specific log file
 # shellcheck disable=SC2034
 log() {
-  local agent="${LOG_AGENT:-review}"
-  printf '[%s] %s: %s\n' "$(date -u '+%Y-%m-%dT%H:%M:%SZ')" "$agent" "$*" >> "$LOGFILE"
+  command log "$@" >> "$LOGFILE"
 }
 
 # Log rotation

supervisor/supervisor-run.sh

@@ -50,13 +50,6 @@ WORKTREE="/tmp/${PROJECT_NAME}-supervisor-run"
 # shellcheck disable=SC2034  # consumed by agent-sdk.sh and env.sh log()
 LOG_AGENT="supervisor"
 
-# Override log() to append to supervisor-specific log file
-# shellcheck disable=SC2034
-log() {
-  local agent="${LOG_AGENT:-supervisor}"
-  printf '[%s] %s: %s\n' "$(date -u '+%Y-%m-%dT%H:%M:%SZ')" "$agent" "$*" >> "$LOG_FILE"
-}
-
 # ── Guards ────────────────────────────────────────────────────────────────
 check_active supervisor
 acquire_cron_lock "/tmp/supervisor-run.lock"