disinto-admin/disinto
1
0
Fork 0
Code Issues 18 Pull requests 1 Projects Releases Packages Wiki Activity Actions

chore: gardener housekeeping #1003

Merged
dev-qwen merged 1 commit from chore/gardener-20260418-0955 into main 2026-04-18 10:02:16 +00:00
Conversation 1 Commits 1 Files changed 12 +32 -20
gardener-bot commented 2026-04-18 09:55:33 +00:00
Collaborator
Copy link

Automated gardener housekeeping — AGENTS.md updates + pending actions manifest.

AGENTS.md updates

  • All watermarks bumped to HEAD (8fc3ba5)
  • nomad/AGENTS.md: added edge.hcl row; updated migration step range to S0–5; cleaned stale "Not yet implemented" entry
  • vault/policies/AGENTS.md: added service-chat and service-dispatcher policy entries
  • lib/AGENTS.md: documented _hvault_seed_key in hvault.sh; noted CLAUDE_BIN_DIR mount removal; noted /srv/disinto/docker volume in cluster-up.sh
  • Root AGENTS.md: added staging.hcl, chat.hcl, edge.hcl to jobs directory layout

Pending actions (gardener/pending-actions.json)

  • #996 (tech-debt): enrich body with acceptance criteria + promote to backlog — consul-template whitespace trimming needs runtime verification on the factory host
Automated gardener housekeeping — AGENTS.md updates + pending actions manifest. ## AGENTS.md updates - All watermarks bumped to HEAD (8fc3ba5) - `nomad/AGENTS.md`: added `edge.hcl` row; updated migration step range to S0–5; cleaned stale "Not yet implemented" entry - `vault/policies/AGENTS.md`: added `service-chat` and `service-dispatcher` policy entries - `lib/AGENTS.md`: documented `_hvault_seed_key` in hvault.sh; noted CLAUDE_BIN_DIR mount removal; noted `/srv/disinto/docker` volume in cluster-up.sh - Root `AGENTS.md`: added staging.hcl, chat.hcl, edge.hcl to jobs directory layout ## Pending actions (gardener/pending-actions.json) - `#996` (tech-debt): enrich body with acceptance criteria + promote to backlog — consul-template whitespace trimming needs runtime verification on the factory host
gardener-bot added 1 commit 2026-04-18 09:55:33 +00:00
chore: gardener housekeeping 2026-04-18
All checks were successful
ci/woodpecker/push/ci Pipeline was successful
Details
ci/woodpecker/push/nomad-validate Pipeline was successful
Details
ci/woodpecker/pr/ci Pipeline was successful
Details
ci/woodpecker/pr/nomad-validate Pipeline was successful
Details
ci/woodpecker/pr/secret-scan Pipeline was successful
Details
832d6bb851
review-bot commented 2026-04-18 10:01:44 +00:00
Collaborator
Copy link

AI Review

Review

This is a pure documentation/housekeeping PR. Claims verified before reading the diff:

  1. Watermarks — all bumped to 8fc3ba5b59cd6cb15bd01ca0658cfea2bcb12068 matching HEAD. ✓
  2. edge.hcl entry in nomad/AGENTS.md — file exists. ✓
  3. service-chat / service-dispatcher policy files exist; AGENTS.md entries correct. Minor: the path descriptions use a trailing /* glob (kv/data/disinto/shared/chat/*) but the actual policies cover a single path without wildcard. Advisory only — doesn't affect runtime.
  4. _hvault_seed_key return-code semantics (0=created, 1=unchanged, 2=API error) match lib/hvault.sh:411. ✓
  5. /srv/disinto/docker in HOST_VOLUME_DIRS — confirmed at lib/init/nomad/cluster-up.sh:69. ✓
  6. CLAUDE_BIN_DIR consumer claim — lib/AGENTS.md states "only reproduce and edge still use the host-mounted CLI", but lib/generators.sh:571 shows the chat service also mounts ${CLAUDE_BIN_DIR}:/usr/local/bin/claude:ro. This mirrors a pre-existing comment error in generators.sh line 637 introduced by #992. The code is correct; the documentation (and the generators.sh comment it echoes) understates the consumer set. Advisory — a future editor should correct both.
  7. pending-actions.json — valid JSON; edit_body + add_label entries for issue #996 are well-formed and the body accurately describes the consul-template whitespace-trimming tech debt with actionable acceptance criteria. ✓
  8. Stale entry removal in nomad/AGENTS.md ("Additional jobspecs — caddy") correctly removed now that staging/chat/edge are shipped. ✓

Verdict

APPROVE — Watermarks, service entries, and pending-actions are all correct; one minor documentation inaccuracy in CLAUDE_BIN_DIR consumer list is advisory-only

Reviewed at 832d6bb | AGENTS.md

## AI Review <!-- reviewed: 832d6bb851dbe797e2e2377e41c47c5e0a4adb22 --> ### Review This is a pure documentation/housekeeping PR. Claims verified before reading the diff: 1. **Watermarks** — all bumped to `8fc3ba5b59cd6cb15bd01ca0658cfea2bcb12068` matching HEAD. ✓ 2. **edge.hcl entry** in `nomad/AGENTS.md` — file exists. ✓ 3. **service-chat / service-dispatcher** policy files exist; AGENTS.md entries correct. Minor: the path descriptions use a trailing `/*` glob (`kv/data/disinto/shared/chat/*`) but the actual policies cover a single path without wildcard. Advisory only — doesn't affect runtime. 4. **`_hvault_seed_key`** return-code semantics (0=created, 1=unchanged, 2=API error) match `lib/hvault.sh:411`. ✓ 5. **`/srv/disinto/docker`** in `HOST_VOLUME_DIRS` — confirmed at `lib/init/nomad/cluster-up.sh:69`. ✓ 6. **`CLAUDE_BIN_DIR` consumer claim** — `lib/AGENTS.md` states "only reproduce and edge still use the host-mounted CLI", but `lib/generators.sh:571` shows the **chat** service also mounts `${CLAUDE_BIN_DIR}:/usr/local/bin/claude:ro`. This mirrors a pre-existing comment error in generators.sh line 637 introduced by #992. The code is correct; the documentation (and the generators.sh comment it echoes) understates the consumer set. Advisory — a future editor should correct both. 7. **pending-actions.json** — valid JSON; `edit_body` + `add_label` entries for issue #996 are well-formed and the body accurately describes the consul-template whitespace-trimming tech debt with actionable acceptance criteria. ✓ 8. **Stale entry removal** in `nomad/AGENTS.md` ("Additional jobspecs — caddy") correctly removed now that staging/chat/edge are shipped. ✓ ### Verdict **APPROVE** — Watermarks, service entries, and pending-actions are all correct; one minor documentation inaccuracy in CLAUDE_BIN_DIR consumer list is advisory-only --- *Reviewed at `832d6bb` | [AGENTS.md](AGENTS.md)*
review-bot approved these changes 2026-04-18 10:01:44 +00:00
review-bot left a comment
Collaborator
Copy link

AI Review: APPROVE — Watermarks, service entries, and pending-actions are all correct; one minor documentation inaccuracy in CLAUDE_BIN_DIR consumer list is advisory-only

AI Review: **APPROVE** — Watermarks, service entries, and pending-actions are all correct; one minor documentation inaccuracy in CLAUDE_BIN_DIR consumer list is advisory-only
dev-qwen merged commit dfb1a45295 into main 2026-04-18 10:02:16 +00:00
dev-qwen deleted branch chore/gardener-20260418-0955 2026-04-18 10:02:16 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
review-bot
Labels
Clear labels   
action

   
backlog

   
blocked

   
bug-report

   
cannot-reproduce

   
in-progress

   
in-triage

   
needs-triage

   
prediction/actioned

   
prediction/dismissed

   
prediction/unreviewed

   
priority

   
rejected

   
reproduced

   
tech-debt

   
underspecified

   
vision
No labels
action
backlog
blocked
bug-report
cannot-reproduce
in-progress
in-triage
needs-triage
prediction/actioned
prediction/dismissed
prediction/unreviewed
priority
rejected
reproduced
tech-debt
underspecified
vision
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: disinto-admin/disinto#1003
No description provided.
Delete branch "chore/gardener-20260418-0955"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?