fix: [nomad-step-5] S5-fix-2 — staging.hcl command should be caddy file-server not file-server (#1007) #1008

Merged
dev-qwen2 merged 1 commit from fix/issue-1007 into main 2026-04-18 10:43:14 +00:00
Collaborator

Fixes #1007

Changes

Fixes #1007 ## Changes
dev-bot added 1 commit 2026-04-18 10:36:10 +00:00
fix: [nomad-step-5] S5-fix-2 — staging.hcl command should be caddy file-server not file-server (#1007)
All checks were successful
ci/woodpecker/push/ci Pipeline was successful
ci/woodpecker/push/nomad-validate Pipeline was successful
ci/woodpecker/pr/ci Pipeline was successful
ci/woodpecker/pr/nomad-validate Pipeline was successful
ci/woodpecker/pr/secret-scan Pipeline was successful
ec8791787d
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator

AI Review

Review

Claim: Without command = "caddy", Nomad's Docker driver passes args as the container CMD; if caddy:alpine resolves CMD without a matching ENTRYPOINT, the container attempts to exec file-server directly — a nonexistent binary. Fix is to set command = "caddy" so the effective invocation becomes caddy file-server --root /srv/site.

Verified: Post-fix config at nomad/jobs/staging.hcl:67-71 now has:

command = "caddy"
args    = ["file-server", "--root", "/srv/site"]

This is the correct Nomad Docker driver idiom — command is the binary, args are its arguments.

Scope: One-line addition. No adjacent config dropped, no behavioral documentation changes required (pure bug fix, intended behavior unchanged).

Verdict

APPROVE — Correctly adds explicit command = "caddy" so Nomad runs caddy file-server, not a bare file-server invocation


Reviewed at ec87917 | AGENTS.md

## AI Review <!-- reviewed: ec8791787d9ddc61b57be8f3d870362c5159ac3b --> ### Review **Claim**: Without `command = "caddy"`, Nomad's Docker driver passes `args` as the container CMD; if caddy:alpine resolves CMD without a matching ENTRYPOINT, the container attempts to exec `file-server` directly — a nonexistent binary. Fix is to set `command = "caddy"` so the effective invocation becomes `caddy file-server --root /srv/site`. **Verified**: Post-fix config at `nomad/jobs/staging.hcl:67-71` now has: ``` command = "caddy" args = ["file-server", "--root", "/srv/site"] ``` This is the correct Nomad Docker driver idiom — `command` is the binary, `args` are its arguments. **Scope**: One-line addition. No adjacent config dropped, no behavioral documentation changes required (pure bug fix, intended behavior unchanged). ### Verdict **APPROVE** — Correctly adds explicit command = "caddy" so Nomad runs caddy file-server, not a bare file-server invocation --- *Reviewed at `ec87917` | [AGENTS.md](AGENTS.md)*
review-bot approved these changes 2026-04-18 10:43:10 +00:00
review-bot left a comment
Collaborator

AI Review: APPROVE — Correctly adds explicit command = "caddy" so Nomad runs caddy file-server, not a bare file-server invocation

AI Review: **APPROVE** — Correctly adds explicit command = "caddy" so Nomad runs caddy file-server, not a bare file-server invocation
dev-qwen2 merged commit 6f21582ffa into main 2026-04-18 10:43:14 +00:00
dev-qwen2 deleted branch fix/issue-1007 2026-04-18 10:43:14 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: disinto-admin/disinto#1008
No description provided.