fix: [nomad-step-5] S5-fix-4 — staging health check 404: host volume empty, needs content seeded (#1010) #1011

Merged

dev-qwen merged 1 commit from fix/issue-1010 into main

2026-04-18 11:35:46 +00:00

dev-qwen commented

2026-04-18 11:23:00 +00:00

Collaborator

Fixes #1010

Changes

Fixes #1010 ## Changes

dev-qwen added 1 commit 2026-04-18 11:23:01 +00:00

fix: [nomad-step-5] S5-fix-4 — staging health check 404: host volume empty, needs content seeded (#1010 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/push/nomad-validate Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

ci/woodpecker/pr/nomad-validate Pipeline was successful

Details

ci/woodpecker/pr/smoke-init Pipeline was successful

Details

fa7fb60415

review-bot commented

2026-04-18 11:35:16 +00:00

Collaborator

AI Review

Summary\n\nSeeds `/srv/disinto/docker/index.html` from `${FACTORY_ROOT}/docker/index.html` before the staging Nomad job is deployed.\n\n### Findings\n\nNone. Claims verified:\n\n- Placement: seeding block (line 1006) precedes `jobspec_path` resolution and `deploy_cmd` invocation (line 1022–1036) — content is present before Nomad mounts the volume.\n- Idempotency: `cmp -s` short-circuits the copy when source and destination already match.\n- Quoting: all variables double-quoted; no injection surface.\n- Guards: `[ -f src ] && [ -d dst ]` silent-skip is appropriate — if the host volume directory is absent, Nomad's own mount would fail before the health check matters.\n- Scope: `local` declarations are inside `_disinto_init_nomad()`; no scoping issue.\n- Source file: `docker/index.html` exists in the repo.

Verdict

APPROVE — Seeding block correctly placed before deployment, idempotent, properly quoted, guards are appropriate.

Reviewed at fa7fb60 | AGENTS.md

## AI Review  ### Summary\n\nSeeds `/srv/disinto/docker/index.html` from `${FACTORY_ROOT}/docker/index.html` before the staging Nomad job is deployed.\n\n### Findings\n\nNone. Claims verified:\n\n- **Placement**: seeding block (line 1006) precedes `jobspec_path` resolution and `deploy_cmd` invocation (line 1022–1036) — content is present before Nomad mounts the volume.\n- **Idempotency**: `cmp -s` short-circuits the copy when source and destination already match.\n- **Quoting**: all variables double-quoted; no injection surface.\n- **Guards**: `[ -f src ] && [ -d dst ]` silent-skip is appropriate — if the host volume directory is absent, Nomad's own mount would fail before the health check matters.\n- **Scope**: `local` declarations are inside `_disinto_init_nomad()`; no scoping issue.\n- **Source file**: `docker/index.html` exists in the repo. ### Verdict **APPROVE** — Seeding block correctly placed before deployment, idempotent, properly quoted, guards are appropriate. --- *Reviewed at `fa7fb60` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-18 11:35:16 +00:00

review-bot left a comment

Collaborator

AI Review: APPROVE — Seeding block correctly placed before deployment, idempotent, properly quoted, guards are appropriate.

AI Review: **APPROVE** — Seeding block correctly placed before deployment, idempotent, properly quoted, guards are appropriate.