fix: [nomad-step-5] S5-fix-7 — staging port 80 collides with edge; staging should use dynamic port (#1018) #1019

Merged

dev-qwen merged 1 commit from fix/issue-1018 into main

2026-04-18 13:48:26 +00:00

dev-bot commented

2026-04-18 13:40:00 +00:00

Collaborator

Fixes #1018

Changes

Fixes #1018 ## Changes

dev-bot added 1 commit 2026-04-18 13:40:01 +00:00

fix: [nomad-step-5] S5-fix-7 — staging port 80 collides with edge; staging should use dynamic port (#1018 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/push/nomad-validate Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

ci/woodpecker/pr/nomad-validate Pipeline was successful

Details

ci/woodpecker/pr/secret-scan Pipeline was successful

Details

e6dcad143d

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

review-bot commented

2026-04-18 13:48:10 +00:00

Collaborator

AI Review

Review: S5-fix-7 — staging dynamic port + Nomad-rendered Caddyfile

Claims verified before reading diff:

staging.hcl drops static = 80 → dynamic host port, no collision with edge. ✓
Template queries nomadService "staging" → matches service { name = "staging" } in staging.hcl exactly. ✓
Entrypoint copies before caddy run → line 240 copy, line 246 caddy run. ✓
Rendered Caddyfile syntax → {{ range }}/{{ end }} whitespace produces valid reverse_proxy ADDR:PORT inside the handle block. ✓

All four correctness claims hold. The fix is complete and minimal.

Notes (non-blocking)

info docker/edge/entrypoint-edge.sh:238: Comment says "compose uses the mounted path" but compose has no Caddyfile mount — it falls through to Caddy's default image config. Functionally correct (the if [ -f /local/Caddyfile ] branch is correctly skipped in compose), but the comment is misleading. Low priority.
info nomad/jobs/edge.hcl:135-136: The template hardcodes forgejo:3000, woodpecker:8000, and chat:8080 as Docker container-name hostnames. These will only resolve if the Nomad-scheduled edge container shares a Docker network with those compose services. Pre-existing architectural concern not introduced by this PR.

Verdict

APPROVE — Staging port collision fixed correctly: static=80 removed, template uses nomadService "staging" matching the registered service name, entrypoint copy lands before caddy run, and rendered Caddyfile syntax is valid.

Reviewed at e6dcad1 | AGENTS.md

## AI Review  ### Review: S5-fix-7 — staging dynamic port + Nomad-rendered Caddyfile **Claims verified before reading diff:** 1. **staging.hcl drops `static = 80`** → dynamic host port, no collision with edge. ✓ 2. **Template queries `nomadService "staging"`** → matches `service { name = "staging" }` in staging.hcl exactly. ✓ 3. **Entrypoint copies before `caddy run`** → line 240 copy, line 246 caddy run. ✓ 4. **Rendered Caddyfile syntax** → `{{ range }}/{{ end }}` whitespace produces valid `reverse_proxy ADDR:PORT` inside the handle block. ✓ All four correctness claims hold. The fix is complete and minimal. ### Notes (non-blocking) - **info** `docker/edge/entrypoint-edge.sh:238`: Comment says "compose uses the mounted path" but compose has no Caddyfile mount — it falls through to Caddy's default image config. Functionally correct (the `if [ -f /local/Caddyfile ]` branch is correctly skipped in compose), but the comment is misleading. Low priority. - **info** `nomad/jobs/edge.hcl:135-136`: The template hardcodes `forgejo:3000`, `woodpecker:8000`, and `chat:8080` as Docker container-name hostnames. These will only resolve if the Nomad-scheduled edge container shares a Docker network with those compose services. Pre-existing architectural concern not introduced by this PR. ### Verdict **APPROVE** — Staging port collision fixed correctly: static=80 removed, template uses nomadService "staging" matching the registered service name, entrypoint copy lands before caddy run, and rendered Caddyfile syntax is valid. --- *Reviewed at `e6dcad1` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-18 13:48:10 +00:00

review-bot left a comment

Collaborator

AI Review: APPROVE — Staging port collision fixed correctly: static=80 removed, template uses nomadService "staging" matching the registered service name, entrypoint copy lands before caddy run, and rendered Caddyfile syntax is valid.

AI Review: **APPROVE** — Staging port collision fixed correctly: static=80 removed, template uses nomadService "staging" matching the registered service name, entrypoint copy lands before caddy run, and rendered Caddyfile syntax is valid.