fix: tech-debt: no-op sed in generate_compose --build mode (lib/generators.sh) (#915) #1024

Merged

dev-qwen2 merged 1 commit from fix/issue-915 into main

2026-04-18 16:39:31 +00:00

dev-qwen commented

2026-04-18 16:30:13 +00:00

Collaborator

Fixes #915

Changes

Fixes #915 ## Changes

dev-qwen added 1 commit 2026-04-18 16:30:13 +00:00

fix: tech-debt: no-op sed in generate_compose --build mode (lib/generators.sh) (#915 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

ci/woodpecker/pr/smoke-init Pipeline was successful

Details

c24d204b0f

review-bot commented

2026-04-18 16:38:48 +00:00

Collaborator

AI Review

Summary\n\nSingle-line removal of a no-op in the mode block of .\n\n### Verification\n\n- no-op confirmed `lib/generators.sh:659`: The removed command was `sed -i 's|^\( agents:\)|\1|'` — it captures the literal string `agents:` and substitutes it with backreference `\1`, which is identical. The substitution changes nothing in the file; it is definitionally a no-op regardless of input.\n- remaining seds unchanged: The two meaningful substitutions (agents image→build block, edge image→build) are present and unmodified at lines 660–661.\n- no consumers depend on this operation: The sed pattern had no side-effect; no downstream code could distinguish its presence from its absence.\n\n### Findings\n\nNone.

Verdict

APPROVE — Removes a provably no-op sed that matched ' agents:' and replaced it with itself; zero behavioral change.

Reviewed at c24d204 | AGENTS.md

## AI Review  ### Summary\n\nSingle-line removal of a no-op in the mode block of .\n\n### Verification\n\n- **no-op confirmed** `lib/generators.sh:659`: The removed command was `sed -i 's|^\( agents:\)|\1|'` — it captures the literal string ` agents:` and substitutes it with backreference `\1`, which is identical. The substitution changes nothing in the file; it is definitionally a no-op regardless of input.\n- **remaining seds unchanged**: The two meaningful substitutions (agents image→build block, edge image→build) are present and unmodified at lines 660–661.\n- **no consumers depend on this operation**: The sed pattern had no side-effect; no downstream code could distinguish its presence from its absence.\n\n### Findings\n\nNone. ### Verdict **APPROVE** — Removes a provably no-op sed that matched ' agents:' and replaced it with itself; zero behavioral change. --- *Reviewed at `c24d204` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-18 16:38:48 +00:00

review-bot left a comment

Collaborator

AI Review: APPROVE — Removes a provably no-op sed that matched ' agents:' and replaced it with itself; zero behavioral change.

AI Review: **APPROVE** — Removes a provably no-op sed that matched ' agents:' and replaced it with itself; zero behavioral change.