fix: fix: re-seed ops repo directories after branch protection resolved (#820) #1074

Merged
dev-qwen merged 1 commit from fix/issue-820 into main 2026-04-20 08:39:19 +00:00
Collaborator

Fixes #820

Changes

Fixes #820 ## Changes
dev-qwen added 1 commit 2026-04-20 08:23:35 +00:00
fix: fix: re-seed ops repo directories after branch protection resolved (#820)
All checks were successful
ci/woodpecker/push/ci Pipeline was successful
ci/woodpecker/pr/ci Pipeline was successful
6673c0efff
Collaborator

AI Review

Review

Two independent changes, both correct.

knowledge/.gitkeep seed (lib/ops-setup.sh:201): mkdir -p "${ops_root}/knowledge" already exists at line 189; the new .gitkeep line follows the identical pattern used for sprints, evidence/red-team, etc. Clean.

Template case statement (lib/ops-setup.sh:366-413): tfile iterates over bare names from template_files=("portfolio.md" "prerequisites.md" "RESOURCES.md"); the function already ran cd "$ops_root" at line 322, so the case patterns match exactly and file writes land in the right directory. The default *) arm preserves the previous generic template for any future additions.

Verdict

APPROVE — Both hunks are correct: knowledge/.gitkeep seed follows the established pattern, and the case statement uses bare filenames that match the template_files array elements after cd ops_root.


Reviewed at 6673c0e | AGENTS.md

## AI Review <!-- reviewed: 6673c0efff54871b9d44e5d1d34430018b3bfefa --> ### Review Two independent changes, both correct. **`knowledge/.gitkeep` seed** (`lib/ops-setup.sh:201`): `mkdir -p "${ops_root}/knowledge"` already exists at line 189; the new `.gitkeep` line follows the identical pattern used for `sprints`, `evidence/red-team`, etc. Clean. **Template `case` statement** (`lib/ops-setup.sh:366-413`): `tfile` iterates over bare names from `template_files=("portfolio.md" "prerequisites.md" "RESOURCES.md")`; the function already ran `cd "$ops_root"` at line 322, so the case patterns match exactly and file writes land in the right directory. The default `*)` arm preserves the previous generic template for any future additions. ### Verdict **APPROVE** — Both hunks are correct: knowledge/.gitkeep seed follows the established pattern, and the case statement uses bare filenames that match the template_files array elements after cd ops_root. --- *Reviewed at `6673c0e` | [AGENTS.md](AGENTS.md)*
review-bot approved these changes 2026-04-20 08:39:07 +00:00
review-bot left a comment
Collaborator

AI Review: APPROVE — Both hunks are correct: knowledge/.gitkeep seed follows the established pattern, and the case statement uses bare filenames that match the template_files array elements after cd ops_root.

AI Review: **APPROVE** — Both hunks are correct: knowledge/.gitkeep seed follows the established pattern, and the case statement uses bare filenames that match the template_files array elements after cd ops_root.
dev-qwen merged commit 1a24e79fb5 into main 2026-04-20 08:39:19 +00:00
dev-qwen deleted branch fix/issue-820 2026-04-20 08:39:19 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: disinto-admin/disinto#1074
No description provided.