fix: strip /staging prefix in Caddyfile before proxying to staging container #1079

New issue

Closed

opened 2026-04-20 15:08:25 +00:00 by disinto-admin · 0 comments

disinto-admin commented

2026-04-20 15:08:25 +00:00

Owner

Goal

Caddyfile routing for /staging/* currently proxies the full path to the staging container, which serves static files from /srv/site without a /staging/ subdir — results in 404. Strip the /staging prefix before proxying so the static server sees / (or /index.html, /assets/…) instead of /staging/….

Evidence

Live probe on 2026-04-20 after docker compose up -d --build edge on disinto-dev-box:

$ curl -sI http://localhost/staging/
HTTP/1.1 404 Not Found
Server: Caddy
Via: 1.1 Caddy

Caddyfile block (/home/johba/disinto/docker/Caddyfile, and lib/generators.sh:862):

handle /staging/* {
    reverse_proxy staging:80
}

Staging container is a Caddy file-server --root /srv/site. Forwarding /staging/index.html → staging:80/staging/index.html, which doesn't exist → 404.

The fix

Add uri strip_prefix /staging before reverse_proxy:

handle /staging/* {
    uri strip_prefix /staging
    reverse_proxy staging:80
}

This rewrites /staging/index.html → /index.html before the proxy call, which the staging file-server resolves correctly.

Apply the edit in lib/generators.sh:862 (the generator is canonical source — the tracked docker/Caddyfile gets overwritten on next disinto init). Do not hand-edit docker/Caddyfile directly.

Acceptance criteria

lib/generators.sh emits uri strip_prefix /staging inside the handle /staging/* block
docker/Caddyfile.template (if present) updated to match
After regenerating the Caddyfile and restarting edge: curl http://localhost/staging/ returns 200 (the staging index) instead of 404
Requests for nested paths (curl http://localhost/staging/assets/foo.css) reach the staging container with the stripped path and return appropriate status
tests/test-caddyfile-routing.sh and/or tests/smoke-edge-subpath.sh assertions pass for the staging path after the fix
shellcheck clean on lib/generators.sh

Affected files

lib/generators.sh — add uri strip_prefix /staging in the staging handle block
tests/test-caddyfile-routing.sh — update assertion to check for the strip_prefix directive (optional)
.woodpecker/edge-subpath.yml — no change expected; caddy-validate should accept the new directive

Vision #623 — edge subpath routing
#1025 — smoke-test tool which surfaced this gap (merged)
Same fix pattern may apply to /forge/* (tracked in separate issue)

## Goal Caddyfile routing for `/staging/*` currently proxies the full path to the staging container, which serves static files from `/srv/site` without a `/staging/` subdir — results in 404. Strip the `/staging` prefix before proxying so the static server sees `/` (or `/index.html`, `/assets/…`) instead of `/staging/…`. ## Evidence Live probe on 2026-04-20 after `docker compose up -d --build edge` on disinto-dev-box: ``` $ curl -sI http://localhost/staging/ HTTP/1.1 404 Not Found Server: Caddy Via: 1.1 Caddy ``` Caddyfile block (`/home/johba/disinto/docker/Caddyfile`, and `lib/generators.sh:862`): ``` handle /staging/* { reverse_proxy staging:80 } ``` Staging container is a Caddy `file-server --root /srv/site`. Forwarding `/staging/index.html` → staging:80/staging/index.html, which doesn't exist → 404. ## The fix Add `uri strip_prefix /staging` before `reverse_proxy`: ``` handle /staging/* { uri strip_prefix /staging reverse_proxy staging:80 } ``` This rewrites `/staging/index.html` → `/index.html` before the proxy call, which the staging file-server resolves correctly. Apply the edit in **`lib/generators.sh:862`** (the generator is canonical source — the tracked `docker/Caddyfile` gets overwritten on next `disinto init`). Do not hand-edit `docker/Caddyfile` directly. ## Acceptance criteria - [ ] `lib/generators.sh` emits `uri strip_prefix /staging` inside the `handle /staging/*` block - [ ] `docker/Caddyfile.template` (if present) updated to match - [ ] After regenerating the Caddyfile and restarting edge: `curl http://localhost/staging/` returns 200 (the staging index) instead of 404 - [ ] Requests for nested paths (`curl http://localhost/staging/assets/foo.css`) reach the staging container with the stripped path and return appropriate status - [ ] `tests/test-caddyfile-routing.sh` and/or `tests/smoke-edge-subpath.sh` assertions pass for the staging path after the fix - [ ] `shellcheck` clean on `lib/generators.sh` ## Affected files - `lib/generators.sh` — add `uri strip_prefix /staging` in the staging handle block - `tests/test-caddyfile-routing.sh` — update assertion to check for the strip_prefix directive (optional) - `.woodpecker/edge-subpath.yml` — no change expected; caddy-validate should accept the new directive ## Related - Vision #623 — edge subpath routing - #1025 — smoke-test tool which surfaced this gap (merged) - Same fix pattern may apply to `/forge/*` (tracked in separate issue)