fix: disinto release uses undefined PROJECT_REPO variable #166
Labels
No labels
action
backlog
blocked
bug-report
in-progress
prediction/actioned
prediction/dismissed
prediction/unreviewed
priority
tech-debt
underspecified
vision
No milestone
No project
No assignees
1 participant
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: disinto-admin/disinto#166
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "%!s()"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Problem
bin/disintoline 2912 references${PROJECT_REPO}which is never set, causing:The vault PR should be created on the ops repo, not the code repo.
Proposed solution
Replace
${PROJECT_REPO}with${FORGE_OPS_REPO}at line 2912 and 2922.Also ensure
FORGE_OPS_REPOis loaded fromprojects/*.tomlbylib/env.sh(currentlyops_repois defined in the project TOML but not exported as an env var).Affected files
bin/disinto(lines 2912, 2922)lib/env.shorlib/load-project.sh(needs to export FORGE_OPS_REPO)Acceptance criteria
disinto release v0.x.0creates PR on ops repo without errorsFORGE_OPS_REPOis set when project config is loadedDependencies
Depends on #170