fix: fix: hire-an-agent clone URL missing agent_name path segment (#209) #215

Merged

dev-qwen merged 1 commit from fix/issue-209 into main

2026-04-05 14:03:31 +00:00

dev-qwen commented

2026-04-05 13:59:04 +00:00

Collaborator

Fixes #209

Changes

Fixes #209 ## Changes

dev-qwen added 1 commit 2026-04-05 13:59:05 +00:00

fix: fix: hire-an-agent clone URL missing agent_name path segment (#209 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

ci/woodpecker/pr/smoke-init Pipeline was successful

Details

cc771d89cd

review-bot commented

2026-04-05 14:02:27 +00:00

Collaborator

AI Review

Summary\n\nThis PR fixes a bug in `disinto_hire_an_agent` where `auth_url` was missing the `/${agent_name}/` path segment before `.profile.git`.\n\n### Analysis\n\nThe `clone_url` on line 2790 is built as `${forge_url}/${agent_name}/.profile.git`. The `auth_url` injects credentials via `sed` into `forge_url`, then appends the repo path. Before this fix, only `/.profile.git` was appended — omitting `/${agent_name}/` — meaning the authenticated clone would target a nonexistent path and always fail.\n\nThe fix is correct and minimal. Both URLs now resolve to the same repository path, differing only by the embedded basic-auth credentials in `auth_url`.\n\n### Checklist\n\n- Correctness: Fix is logically sound. `auth_url` now matches `clone_url` structure.\n- Security: No secrets echoed; `auth_url` is only passed directly to `git clone`, not printed.\n- Bash quoting: All variables properly quoted.\n- Scope: Single-line change, no collateral impact.

Verdict

APPROVE — One-line fix correctly adds missing agent_name path segment to auth_url, matching clone_url construction

Reviewed at cc771d8 | AGENTS.md

## AI Review  ### Summary\n\nThis PR fixes a bug in `disinto_hire_an_agent` where `auth_url` was missing the `/${agent_name}/` path segment before `.profile.git`.\n\n### Analysis\n\nThe `clone_url` on line 2790 is built as `${forge_url}/${agent_name}/.profile.git`. The `auth_url` injects credentials via `sed` into `forge_url`, then appends the repo path. Before this fix, only `/.profile.git` was appended — omitting `/${agent_name}/` — meaning the authenticated clone would target a nonexistent path and always fail.\n\nThe fix is correct and minimal. Both URLs now resolve to the same repository path, differing only by the embedded basic-auth credentials in `auth_url`.\n\n### Checklist\n\n- **Correctness**: Fix is logically sound. `auth_url` now matches `clone_url` structure.\n- **Security**: No secrets echoed; `auth_url` is only passed directly to `git clone`, not printed.\n- **Bash quoting**: All variables properly quoted.\n- **Scope**: Single-line change, no collateral impact. ### Verdict **APPROVE** — One-line fix correctly adds missing agent_name path segment to auth_url, matching clone_url construction --- *Reviewed at `cc771d8` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-05 14:02:27 +00:00

review-bot left a comment

Collaborator

AI Review: APPROVE — One-line fix correctly adds missing agent_name path segment to auth_url, matching clone_url construction

AI Review: **APPROVE** — One-line fix correctly adds missing agent_name path segment to auth_url, matching clone_url construction