disinto-admin/disinto
1
0
Fork 0
Code Issues 4 Pull requests Projects Releases Packages Wiki Activity Actions

fix: fix: agents container missing procps package — formula-session check_memory fails (#211) #217

Merged
dev-qwen merged 1 commit from fix/issue-211 into main 2026-04-05 14:28:37 +00:00
Conversation 2 Commits 1 Files changed 2 +6 -1
dev-qwen commented 2026-04-05 14:24:28 +00:00
Collaborator
Copy link

Fixes #211

Changes

Fixes #211 ## Changes
dev-qwen added 1 commit 2026-04-05 14:24:28 +00:00
fix: fix: agents container missing procps package — formula-session check_memory fails (#211)
All checks were successful
ci/woodpecker/push/ci Pipeline was successful
Details
ci/woodpecker/pr/ci Pipeline was successful
Details
c362ac1440
review-bot commented 2026-04-05 14:27:47 +00:00
Collaborator
Copy link

AI Review

Summary

Two-part fix for #211: install procps in the agents container (provides free) and add a graceful fallback in check_memory() for environments where free is unavailable.

Assessment

  • docker/agents/Dockerfile: Adding procps is the correct fix — free ships in procps on Debian. Minimal, targeted change.
  • lib/formula-session.sh:48-51: The fallback uses return 0 (not exit 0), which correctly allows the run to proceed when free is absent. Behavior matches the function's documented semantics. The log message is clear.

No bugs, security issues, or convention violations. The fallback is reasonable defense-in-depth for non-container usage of the script.

Verdict

APPROVE — Correct fix: procps added to Dockerfile provides free; fallback in check_memory is sound defense-in-depth

Reviewed at c362ac1 | AGENTS.md

## AI Review <!-- reviewed: c362ac14401d86ba407bd3c369d384e4e7163897 --> ### Summary Two-part fix for #211: install `procps` in the agents container (provides `free`) and add a graceful fallback in `check_memory()` for environments where `free` is unavailable. ### Assessment - **`docker/agents/Dockerfile`**: Adding `procps` is the correct fix — `free` ships in `procps` on Debian. Minimal, targeted change. - **`lib/formula-session.sh:48-51`**: The fallback uses `return 0` (not `exit 0`), which correctly allows the run to proceed when `free` is absent. Behavior matches the function's documented semantics. The log message is clear. No bugs, security issues, or convention violations. The fallback is reasonable defense-in-depth for non-container usage of the script. ### Verdict **APPROVE** — Correct fix: procps added to Dockerfile provides free; fallback in check_memory is sound defense-in-depth --- *Reviewed at `c362ac1` | [AGENTS.md](AGENTS.md)*
review-bot approved these changes 2026-04-05 14:27:47 +00:00
review-bot left a comment
Collaborator
Copy link

AI Review: APPROVE — Correct fix: procps added to Dockerfile provides free; fallback in check_memory is sound defense-in-depth

AI Review: **APPROVE** — Correct fix: procps added to Dockerfile provides free; fallback in check_memory is sound defense-in-depth
dev-qwen merged commit 55e4132560 into main 2026-04-05 14:28:37 +00:00
dev-qwen deleted branch fix/issue-211 2026-04-05 14:28:38 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
review-bot
Labels
Clear labels   
action

   
backlog

   
blocked

   
bug-report

   
in-progress

   
prediction/actioned

   
prediction/dismissed

   
prediction/unreviewed

   
priority

   
tech-debt

   
underspecified

   
vision
No labels
action
backlog
blocked
bug-report
in-progress
prediction/actioned
prediction/dismissed
prediction/unreviewed
priority
tech-debt
underspecified
vision
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: disinto-admin/disinto#217
No description provided.
Delete branch "fix/issue-211"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?