fix: agent_run nudges unnecessarily when worktree is clean and no push expected #219

New issue

Closed

opened 2026-04-05 14:39:02 +00:00 by dev-bot · 0 comments

dev-bot commented

2026-04-05 14:39:02 +00:00

Collaborator

Problem

In lib/agent-sdk.sh agent_run (lines 74-82), when no push is detected after the claude session, the nudge fires regardless of whether the worktree has changes:

If there are uncommitted changes: nudge says "commit and push" (correct)
If worktree is clean and no push: nudge says "complete the implementation" (wasteful)

The second case is a false positive for agents that work via API (architect, planner) or sessions that correctly determined there's nothing to do. The nudge costs tokens and Claude just explains why there's nothing to push.

Observed

Architect run: no vision issues to decompose, worktree clean, claude correctly finished. Got nudged anyway, spent 12 extra turns at $0.28 explaining why there's nothing to push.

Proposed solution

Skip the nudge when the worktree is completely clean (no changes, no untracked files):

if [ -z "$has_pushed" ]; then
  if [ -n "$has_changes" ]; then
    # Nudge: there are uncommitted changes
    nudge="You have uncommitted changes. Commit them and push."
    log "agent_run: nudging (uncommitted changes)"
    # ... resume with nudge
  else
    log "agent_run: no push and no changes — skipping nudge"
  fi
fi

Affected files

lib/agent-sdk.sh (agent_run, lines 74-90)

Acceptance criteria

No nudge when worktree is clean and nothing was pushed
Nudge still fires when there are uncommitted changes but no push
Dev agent (which always pushes) is unaffected

## Problem In lib/agent-sdk.sh agent_run (lines 74-82), when no push is detected after the claude session, the nudge fires regardless of whether the worktree has changes: - If there are uncommitted changes: nudge says "commit and push" (correct) - If worktree is clean and no push: nudge says "complete the implementation" (wasteful) The second case is a false positive for agents that work via API (architect, planner) or sessions that correctly determined there's nothing to do. The nudge costs tokens and Claude just explains why there's nothing to push. ## Observed Architect run: no vision issues to decompose, worktree clean, claude correctly finished. Got nudged anyway, spent 12 extra turns at $0.28 explaining why there's nothing to push. ## Proposed solution Skip the nudge when the worktree is completely clean (no changes, no untracked files): if [ -z "$has_pushed" ]; then if [ -n "$has_changes" ]; then # Nudge: there are uncommitted changes nudge="You have uncommitted changes. Commit them and push." log "agent_run: nudging (uncommitted changes)" # ... resume with nudge else log "agent_run: no push and no changes — skipping nudge" fi fi ## Affected files - lib/agent-sdk.sh (agent_run, lines 74-90) ## Acceptance criteria - [ ] No nudge when worktree is clean and nothing was pushed - [ ] Nudge still fires when there are uncommitted changes but no push - [ ] Dev agent (which always pushes) is unaffected