fix: remove hardcoded 'johba' references — use dynamic project config instead #241

New issue

Closed

opened 2026-04-05 16:53:59 +00:00 by dev-bot · 0 comments

dev-bot commented

2026-04-05 16:53:59 +00:00

Collaborator

Problem

The codebase has hardcoded references to 'johba' (the original developer's username) scattered across multiple files. When other users run disinto init for their own project, these references are wrong.

Examples found:

bin/disinto line ~974: ${forge_url}/api/v1/users/johba/repos — hardcoded fallback in setup_ops_repo
formulas/release.toml: $FORGE_URL/api/v1/repos/johba/disinto/... in step descriptions
docker-compose.yml template: FORGE_OPS_REPO=johba/disinto-ops
Various references in step descriptions across formulas

Proposed solution

Audit and replace all hardcoded 'johba' references with dynamic values from project config:

${FORGE_REPO} for the code repo (e.g. disinto-admin/disinto)
${FORGE_OPS_REPO} for the ops repo (e.g. disinto-admin/disinto-ops)
disinto-admin for the admin user (this is the standard admin account name)

To find all occurrences:

grep -rn 'johba' bin/ lib/ formulas/ docker/ --include='*.sh' --include='*.toml' --include='*.yml'

Formula step descriptions that reference specific API URLs should use variable placeholders like $FORGE_URL/api/v1/repos/$FORGE_REPO/... instead of hardcoded paths.

Affected files

bin/disinto (setup_ops_repo fallback, possibly others)
formulas/*.toml (step descriptions with hardcoded repo paths)
docker/ templates (compose env vars)

Acceptance criteria

grep -rn 'johba' bin/ lib/ formulas/ docker/ returns zero matches
All repo references use config-derived variables
disinto init on a fresh box with a different username produces no johba references

## Problem The codebase has hardcoded references to 'johba' (the original developer's username) scattered across multiple files. When other users run `disinto init` for their own project, these references are wrong. Examples found: - bin/disinto line ~974: `${forge_url}/api/v1/users/johba/repos` — hardcoded fallback in setup_ops_repo - formulas/release.toml: `$FORGE_URL/api/v1/repos/johba/disinto/...` in step descriptions - docker-compose.yml template: FORGE_OPS_REPO=johba/disinto-ops - Various references in step descriptions across formulas ## Proposed solution Audit and replace all hardcoded 'johba' references with dynamic values from project config: - `${FORGE_REPO}` for the code repo (e.g. disinto-admin/disinto) - `${FORGE_OPS_REPO}` for the ops repo (e.g. disinto-admin/disinto-ops) - `disinto-admin` for the admin user (this is the standard admin account name) To find all occurrences: grep -rn 'johba' bin/ lib/ formulas/ docker/ --include='*.sh' --include='*.toml' --include='*.yml' Formula step descriptions that reference specific API URLs should use variable placeholders like $FORGE_URL/api/v1/repos/$FORGE_REPO/... instead of hardcoded paths. ## Affected files - bin/disinto (setup_ops_repo fallback, possibly others) - formulas/*.toml (step descriptions with hardcoded repo paths) - docker/ templates (compose env vars) ## Acceptance criteria - [ ] `grep -rn 'johba' bin/ lib/ formulas/ docker/` returns zero matches - [ ] All repo references use config-derived variables - [ ] `disinto init` on a fresh box with a different username produces no johba references