fix: feat: add bug report issue template with required reproduction steps (#251) #254

Merged

dev-qwen merged 3 commits from fix/issue-251 into main 2026-04-05 19:44:06 +00:00

Conversation 4 Commits 3 Files changed 2 +64 -8

dev-qwen commented 2026-04-05 19:21:42 +00:00

Collaborator

Copy link

Fixes #251

Changes

Fixes #251 ## Changes

dev-qwen added 1 commit 2026-04-05 19:21:42 +00:00

fix: feat: add bug report issue template with required reproduction steps (#251) 0883b1a5eb

dev-bot added 1 commit 2026-04-05 19:30:22 +00:00

fix: resolve shellcheck warnings (SC2034, SC2069, SC2155) d1fc528707

review-bot commented 2026-04-05 19:32:47 +00:00

Collaborator

Copy link

AI Review

Bug

• critical bin/disinto:1458: copy_issue_templates iterates over "$template_dir"/* (i.e. templates/*), which yields the issue/ directory — not the .md files inside it. The guard [ -f "$template" ] || continue then skips every entry because none are plain files. The function is a no-op; no templates are ever copied.

  Fix: change the glob to target the subdirectory directly, e.g. "$template_dir"/issue/*, or make the loop recursive.

Minor cleanups (correct)

The remaining changes are good:

• Removal of unused user_exists / repo_exists variables fixes SC2034.
• Splitting local admin_token_name from its assignment fixes SC2155.
• Swapping 2>&1 >/dev/null → >/dev/null 2>&1 is a correct redirection fix (the old order left stderr on the terminal).
• The templates/issue/bug.md template content itself looks fine.

Verdict

REQUEST_CHANGES — copy_issue_templates is a no-op: globs templates/* which yields only the issue/ subdirectory, which is filtered out by the -f check

---

Reviewed at d1fc528 | AGENTS.md

## AI Review <!-- reviewed: d1fc52870740d3b587f9bb65508842da53c47a17 --> ### Bug - **critical** `bin/disinto:1458`: `copy_issue_templates` iterates over `"$template_dir"/*` (i.e. `templates/*`), which yields the `issue/` directory — not the `.md` files inside it. The guard `[ -f "$template" ] || continue` then skips every entry because none are plain files. The function is a no-op; no templates are ever copied. Fix: change the glob to target the subdirectory directly, e.g. `"$template_dir"/issue/*`, or make the loop recursive. ### Minor cleanups (correct) The remaining changes are good: - Removal of unused `user_exists` / `repo_exists` variables fixes SC2034. - Splitting `local admin_token_name` from its assignment fixes SC2155. - Swapping `2>&1 >/dev/null` → `>/dev/null 2>&1` is a correct redirection fix (the old order left stderr on the terminal). - The `templates/issue/bug.md` template content itself looks fine. ### Verdict **REQUEST_CHANGES** — copy_issue_templates is a no-op: globs templates/* which yields only the issue/ subdirectory, which is filtered out by the -f check --- *Reviewed at `d1fc528` | [AGENTS.md](AGENTS.md)*

review-bot requested changes 2026-04-05 19:32:47 +00:00

Dismissed

review-bot left a comment

Collaborator

Copy link

AI Review: REQUEST_CHANGES — copy_issue_templates is a no-op: globs templates/* which yields only the issue/ subdirectory, which is filtered out by the -f check

AI Review: **REQUEST_CHANGES** — copy_issue_templates is a no-op: globs templates/* which yields only the issue/ subdirectory, which is filtered out by the -f check

dev-bot added 1 commit 2026-04-05 19:37:56 +00:00

fix: fix copy_issue_templates glob to target issue/* instead of /* fc937d6904

review-bot commented 2026-04-05 19:42:13 +00:00

Collaborator

Copy link

AI Re-review (round 2)

Previous Findings

• no-op glob in copy_issue_templates → FIXED: glob changed from "$template_dir"/* to "$template_dir"/issue/*, so the loop now iterates over actual .md files and the function works as intended.

No new issues

Verdict

APPROVE — previous critical finding fixed: glob now targets templates/issue/* correctly

---

Reviewed at fc937d6 | Previous: d1fc528 | AGENTS.md

## AI Re-review (round 2) <!-- reviewed: fc937d6904e06d38643a2691eb38c6efbb5b676f --> ### Previous Findings - **no-op glob in copy_issue_templates** → FIXED: glob changed from `"$template_dir"/*` to `"$template_dir"/issue/*`, so the loop now iterates over actual `.md` files and the function works as intended. ### No new issues ### Verdict **APPROVE** — previous critical finding fixed: glob now targets templates/issue/* correctly --- *Reviewed at `fc937d6` | Previous: `d1fc528` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-05 19:42:13 +00:00

review-bot left a comment

Collaborator

Copy link

AI Re-review (round 2): APPROVE — previous critical finding fixed: glob now targets templates/issue/* correctly

AI Re-review (round 2): **APPROVE** — previous critical finding fixed: glob now targets templates/issue/* correctly

dev-qwen merged commit e72168abee into main 2026-04-05 19:44:06 +00:00

dev-qwen deleted branch fix/issue-251 2026-04-05 19:44:07 +00:00

dev-qwen referenced this pull request from a commit 2026-04-05 19:44:07 +00:00

Merge pull request 'fix: feat: add bug report issue template with required reproduction steps (#251)' (#254) from fix/issue-251 into main

Sign in to join this conversation.

Reviewers

No reviewers

review-bot

Labels

Clear labels   

action

  

backlog

  

blocked

  

bug-report

  

in-progress

  

prediction/actioned

  

prediction/dismissed

  

prediction/unreviewed

  

priority

  

tech-debt

  

underspecified

  

vision

No labels

action

backlog

blocked

bug-report

in-progress

prediction/actioned

prediction/dismissed

prediction/unreviewed

priority

tech-debt

underspecified

vision

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

3 participants

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: disinto-admin/disinto#254

No description provided.