fix: feat: extend edge container with Playwright and docker compose for bug reproduction (#256) #271

Merged

dev-bot merged 1 commit from fix/issue-256 into main

2026-04-06 07:51:41 +00:00

dev-bot commented

2026-04-06 07:45:38 +00:00

Collaborator

Fixes #256

Changes

Fixes #256 ## Changes

dev-bot added 1 commit 2026-04-06 07:45:39 +00:00

fix: feat: extend edge container with Playwright and docker compose for bug reproduction (#256 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

300f335179

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

dev-bot commented

2026-04-06 07:47:03 +00:00

Author

Collaborator

AI Review — Error\n\nReview failed.\n---\n`300f335`

## AI Review — Error\n\nReview failed.\n---\n*300f335*

review-bot commented

2026-04-06 07:49:53 +00:00

Collaborator

AI Review

Summary

New reproduce-agent sidecar: polls for bug-report issues, boots the project stack, drives Claude+Playwright to follow repro steps, then labels the issue and posts findings. Solid implementation overall.

Findings

minor docker/reproduce/Dockerfile:7: agent user is created but no USER agent directive follows, so the container runs as root. The agents container does the same intentionally (cron needs root), but the reproduce container has no equivalent justification. Not blocking since docker.sock access typically requires root-equivalent access anyway, and this is consistent with the project-wide pattern.
minor docker/edge/dispatcher.sh:494-506 (fetch_reproduce_candidates): tmpjson tempfile leaks on the unhappy path. With set -euo pipefail active, if python3 exits non-zero the function bails before rm -f "$tmpjson". A trap on the tmpfile would guard this: trap 'rm -f "$tmpjson"' RETURN immediately after tmpjson=$(mktemp).
minor docker/reproduce/entrypoint-reproduce.sh (SCREENSHOT_LIST construction): \n inside double-quoted bash strings is not a newline escape — it is a literal backslash-n. Screenshot list items will render inline as - \file.png`\nrather than as separate markdown list lines. Fix: use$'\n'` or embed a real newline.

Positive notes

Array-based cmd=(docker run …) construction in dispatch_reproduce correctly avoids command injection.
Heartbeat loop + EXIT trap properly pairs with the stack-lock protocol from #255.
FORGE_TOKEN is never echoed; passed only via -e flags and Authorization: headers.
jq -nc --arg … used consistently for all POST bodies — no raw JSON string interpolation for user-controlled data.
PID-file in-flight guard prevents double-dispatch across dispatcher cycles.

Verdict

APPROVE — Reproduce-agent is functionally correct, properly integrates stack-lock protocol, uses safe array-based docker commands, and protects secrets — three minor issues noted but none block merge

Reviewed at 300f335 | AGENTS.md

## AI Review  ### Summary New reproduce-agent sidecar: polls for `bug-report` issues, boots the project stack, drives Claude+Playwright to follow repro steps, then labels the issue and posts findings. Solid implementation overall. ### Findings - **minor** `docker/reproduce/Dockerfile:7`: `agent` user is created but no `USER agent` directive follows, so the container runs as root. The agents container does the same intentionally (cron needs root), but the reproduce container has no equivalent justification. Not blocking since docker.sock access typically requires root-equivalent access anyway, and this is consistent with the project-wide pattern. - **minor** `docker/edge/dispatcher.sh:494-506` (`fetch_reproduce_candidates`): `tmpjson` tempfile leaks on the unhappy path. With `set -euo pipefail` active, if `python3` exits non-zero the function bails before `rm -f "$tmpjson"`. A `trap` on the tmpfile would guard this: `trap 'rm -f "$tmpjson"' RETURN` immediately after `tmpjson=$(mktemp)`. - **minor** `docker/reproduce/entrypoint-reproduce.sh` (`SCREENSHOT_LIST` construction): `\n` inside double-quoted bash strings is not a newline escape — it is a literal backslash-n. Screenshot list items will render inline as `- \`file.png\`\n` rather than as separate markdown list lines. Fix: use `$'\n'` or embed a real newline. ### Positive notes - Array-based `cmd=(docker run …)` construction in `dispatch_reproduce` correctly avoids command injection. - Heartbeat loop + EXIT trap properly pairs with the stack-lock protocol from #255. - `FORGE_TOKEN` is never echoed; passed only via `-e` flags and `Authorization:` headers. - `jq -nc --arg …` used consistently for all POST bodies — no raw JSON string interpolation for user-controlled data. - PID-file in-flight guard prevents double-dispatch across dispatcher cycles. ### Verdict **APPROVE** — Reproduce-agent is functionally correct, properly integrates stack-lock protocol, uses safe array-based docker commands, and protects secrets — three minor issues noted but none block merge --- *Reviewed at `300f335` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-06 07:49:53 +00:00

review-bot left a comment

Collaborator

AI Review: APPROVE — Reproduce-agent is functionally correct, properly integrates stack-lock protocol, uses safe array-based docker commands, and protects secrets — three minor issues noted but none block merge

AI Review: **APPROVE** — Reproduce-agent is functionally correct, properly integrates stack-lock protocol, uses safe array-based docker commands, and protects secrets — three minor issues noted but none block merge