refactor: extract push_to_forge() and webhook setup from bin/disinto into lib/forge-push.sh #302

Closed
opened 2026-04-06 17:53:32 +00:00 by dev-bot · 0 comments
Collaborator

Context

Part of #284 — incremental extraction of bin/disinto into focused lib/ modules.

What to extract

The push_to_forge() function (~158 lines) handles pushing to the Forge remote, verifying the push, and webhook setup.

How

  1. Create lib/forge-push.sh with push_to_forge()
  2. Globals expected: FORGE_URL, FORGE_TOKEN, FACTORY_ROOT, PRIMARY_BRANCH. Assert they are set.
  3. In bin/disinto, replace the function body with: source "${FACTORY_ROOT}/lib/forge-push.sh"
  4. smoke-init CI must pass

Affected files

  • bin/disinto (remove push_to_forge body, add source)
  • lib/forge-push.sh (new file)

Acceptance criteria

  • lib/forge-push.sh contains push_to_forge()
  • bin/disinto sources lib/forge-push.sh
  • smoke-init CI step passes
  • ShellCheck passes
## Context Part of #284 — incremental extraction of bin/disinto into focused lib/ modules. ## What to extract The push_to_forge() function (~158 lines) handles pushing to the Forge remote, verifying the push, and webhook setup. ## How 1. Create lib/forge-push.sh with push_to_forge() 2. Globals expected: FORGE_URL, FORGE_TOKEN, FACTORY_ROOT, PRIMARY_BRANCH. Assert they are set. 3. In bin/disinto, replace the function body with: source "${FACTORY_ROOT}/lib/forge-push.sh" 4. smoke-init CI must pass ## Affected files - bin/disinto (remove push_to_forge body, add source) - lib/forge-push.sh (new file) ## Acceptance criteria - [ ] lib/forge-push.sh contains push_to_forge() - [ ] bin/disinto sources lib/forge-push.sh - [ ] smoke-init CI step passes - [ ] ShellCheck passes
dev-bot added the
backlog
label 2026-04-06 17:53:32 +00:00
dev-bot self-assigned this 2026-04-06 19:29:05 +00:00
dev-bot added
in-progress
and removed
backlog
labels 2026-04-06 19:29:05 +00:00
dev-bot removed their assignment 2026-04-06 19:39:02 +00:00
dev-bot removed the
in-progress
label 2026-04-06 19:39:03 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: disinto-admin/disinto#302
No description provided.