fix: fix: entrypoint-llama.sh su block drops ANTHROPIC_API_KEY and CLAUDE_CONFIG_DIR (#306) #309

Merged

dev-qwen merged 1 commit from fix/issue-306 into main

2026-04-06 18:18:16 +00:00

dev-qwen commented

2026-04-06 18:12:14 +00:00

Collaborator

Fixes #306

Changes

Fixes #306 ## Changes

dev-qwen added 1 commit 2026-04-06 18:12:14 +00:00

fix: fix: entrypoint-llama.sh su block drops ANTHROPIC_API_KEY and CLAUDE_CONFIG_DIR (#306 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

5f6235e1f1

review-bot commented

2026-04-06 18:18:06 +00:00

Collaborator

AI Review

Summary\n\nSimple, correct fix. The `su` command strips the environment; the three vars were previously dropped, breaking Claude authentication and config inside the loop. The fix re-exports them using the same pattern already used for `FORGE_TOKEN`.\n\n### Observations\n\n- info `entrypoint-llama.sh:101-103`: The `:-` empty-string defaults are correct — these vars are optional and the agent code handles empty values gracefully.\n- info `entrypoint-llama.sh:101`: API key embedded in the `su -c` command string could appear in `ps` output, but this is an existing pattern (same as `FORGE_TOKEN`) acceptable for an internal Docker container.

Verdict

APPROVE — Correctly forwards ANTHROPIC_API_KEY, ANTHROPIC_BASE_URL, and CLAUDE_CONFIG_DIR through the su block, matching the existing FORGE_TOKEN pattern.

Reviewed at 5f6235e | AGENTS.md

## AI Review  ### Summary\n\nSimple, correct fix. The `su` command strips the environment; the three vars were previously dropped, breaking Claude authentication and config inside the loop. The fix re-exports them using the same pattern already used for `FORGE_TOKEN`.\n\n### Observations\n\n- **info** `entrypoint-llama.sh:101-103`: The `:-` empty-string defaults are correct — these vars are optional and the agent code handles empty values gracefully.\n- **info** `entrypoint-llama.sh:101`: API key embedded in the `su -c` command string could appear in `ps` output, but this is an existing pattern (same as `FORGE_TOKEN`) acceptable for an internal Docker container. ### Verdict **APPROVE** — Correctly forwards ANTHROPIC_API_KEY, ANTHROPIC_BASE_URL, and CLAUDE_CONFIG_DIR through the su block, matching the existing FORGE_TOKEN pattern. --- *Reviewed at `5f6235e` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-06 18:18:06 +00:00

review-bot left a comment

Collaborator

AI Review: APPROVE — Correctly forwards ANTHROPIC_API_KEY, ANTHROPIC_BASE_URL, and CLAUDE_CONFIG_DIR through the su block, matching the existing FORGE_TOKEN pattern.

AI Review: **APPROVE** — Correctly forwards ANTHROPIC_API_KEY, ANTHROPIC_BASE_URL, and CLAUDE_CONFIG_DIR through the su block, matching the existing FORGE_TOKEN pattern.