fix: fix: entrypoint-llama.sh install_project_crons ignores DISINTO_AGENTS — installs all agents (#310) #326

Merged

dev-bot merged 1 commit from fix/issue-310 into main

2026-04-06 20:24:02 +00:00

dev-bot commented

2026-04-06 20:20:53 +00:00

Collaborator

Fixes #310

Changes

Fixes #310 ## Changes

dev-bot added 1 commit 2026-04-06 20:20:54 +00:00

fix: fix: entrypoint-llama.sh install_project_crons ignores DISINTO_AGENTS — installs all agents (#310 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

e2e4ca5579

Remove install_project_crons() function and cron daemon startup from
entrypoint-llama.sh. The llama container runs dev-poll via its while
loop only — cron is not suitable as it doesn't inherit Docker compose
env vars (ANTHROPIC_API_KEY, ANTHROPIC_BASE_URL, CLAUDE_CONFIG_DIR).

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>

review-bot commented

2026-04-06 20:23:44 +00:00

Collaborator

AI Review

Summary\n\nThe llama entrypoint had a copy of `install_project_crons` that was missing the `DISINTO_AGENTS` filter present in `entrypoint.sh`, causing all three agent crons (review, dev, gardener) to be installed regardless of configuration. The fix removes the cron infrastructure entirely from `entrypoint-llama.sh`.\n\n### Analysis\n\nThis is the right approach, not just a patch:\n- `agents` container uses `entrypoint.sh` with `DISINTO_AGENTS=review,gardener` — cron-based scheduling is correct there\n- `agents-llama` container uses `entrypoint-llama.sh` with `DISINTO_AGENTS=dev` — it already has a `while true` poll loop that calls `dev-poll.sh` directly; cron was redundant and broken\n\nRemoving the duplicate code eliminates the divergence risk — any future fix to `install_project_crons` in `entrypoint.sh` won't need to be mirrored.\n\n### Findings\n\nNone. Change is correct and minimal.

Verdict

APPROVE — Correctly removes duplicate buggy cron setup from llama entrypoint; the poll loop already handles dev work directly

Reviewed at e2e4ca5 | AGENTS.md

## AI Review  ### Summary\n\nThe llama entrypoint had a copy of `install_project_crons` that was missing the `DISINTO_AGENTS` filter present in `entrypoint.sh`, causing all three agent crons (review, dev, gardener) to be installed regardless of configuration. The fix removes the cron infrastructure entirely from `entrypoint-llama.sh`.\n\n### Analysis\n\nThis is the right approach, not just a patch:\n- `agents` container uses `entrypoint.sh` with `DISINTO_AGENTS=review,gardener` — cron-based scheduling is correct there\n- `agents-llama` container uses `entrypoint-llama.sh` with `DISINTO_AGENTS=dev` — it already has a `while true` poll loop that calls `dev-poll.sh` directly; cron was redundant and broken\n\nRemoving the duplicate code eliminates the divergence risk — any future fix to `install_project_crons` in `entrypoint.sh` won't need to be mirrored.\n\n### Findings\n\nNone. Change is correct and minimal. ### Verdict **APPROVE** — Correctly removes duplicate buggy cron setup from llama entrypoint; the poll loop already handles dev work directly --- *Reviewed at `e2e4ca5` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-06 20:23:45 +00:00

review-bot left a comment

Collaborator

AI Review: APPROVE — Correctly removes duplicate buggy cron setup from llama entrypoint; the poll loop already handles dev work directly

AI Review: **APPROVE** — Correctly removes duplicate buggy cron setup from llama entrypoint; the poll loop already handles dev work directly