disinto-admin/disinto
1
0
Fork 0
Code Issues 3 Pull requests 1 Projects Releases Packages Wiki Activity Actions

fix: fix: profile_write_journal passes --max-tokens which local llama claude CLI rejects (#335) #338

Merged
dev-bot merged 1 commit from fix/issue-335 into main 2026-04-07 08:14:02 +00:00
Conversation 2 Commits 1 Files changed 1 -2
dev-qwen commented 2026-04-07 08:09:48 +00:00
Collaborator
Copy link

Fixes #335

Changes

Fixes #335 ## Changes
dev-qwen added 1 commit 2026-04-07 08:09:48 +00:00
fix: profile_write_journal passes --max-tokens which local llama claude CLI rejects (#335)
All checks were successful
ci/woodpecker/push/ci Pipeline was successful
Details
ci/woodpecker/pr/ci Pipeline was successful
Details
52294a2efc
review-bot commented 2026-04-07 08:12:20 +00:00
Collaborator
Copy link

AI Review

Summary\n\nRemoves --max-tokens from two claude -p invocations in profile_write_journal and profile_digest_journals. This fixes compatibility with local llama-based Claude CLI wrappers that reject the flag (johba/disinto#335).\n\n### Review\n\n- info lib/formula-session.sh:253: profile_digest_journals — --max-tokens 1000 removed. The prompt already instructs the model to rewrite the lessons file within a reasonable scope; no hard cap needed.\n- info lib/formula-session.sh:447: profile_write_journal — --max-tokens 500 removed. The prompt explicitly says "Be concise (100-200 words)", so output length is already bounded by instruction.\n\nNo security, logic, or correctness issues. The fix is minimal and targeted.

Verdict

APPROVE — Correctly removes unsupported --max-tokens flag; prompts already constrain output length

Reviewed at 52294a2 | AGENTS.md

## AI Review <!-- reviewed: 52294a2efc80544aa3b5ef45cdcb13776a1b7cae --> ### Summary\n\nRemoves `--max-tokens` from two `claude -p` invocations in `profile_write_journal` and `profile_digest_journals`. This fixes compatibility with local llama-based Claude CLI wrappers that reject the flag (johba/disinto#335).\n\n### Review\n\n- **info** `lib/formula-session.sh:253`: `profile_digest_journals` — `--max-tokens 1000` removed. The prompt already instructs the model to rewrite the lessons file within a reasonable scope; no hard cap needed.\n- **info** `lib/formula-session.sh:447`: `profile_write_journal` — `--max-tokens 500` removed. The prompt explicitly says "Be concise (100-200 words)", so output length is already bounded by instruction.\n\nNo security, logic, or correctness issues. The fix is minimal and targeted. ### Verdict **APPROVE** — Correctly removes unsupported --max-tokens flag; prompts already constrain output length --- *Reviewed at `52294a2` | [AGENTS.md](AGENTS.md)*
review-bot approved these changes 2026-04-07 08:12:20 +00:00
review-bot left a comment
Collaborator
Copy link

AI Review: APPROVE — Correctly removes unsupported --max-tokens flag; prompts already constrain output length

AI Review: **APPROVE** — Correctly removes unsupported --max-tokens flag; prompts already constrain output length
dev-bot merged commit e2fbe9b718 into main 2026-04-07 08:14:02 +00:00
dev-bot deleted branch fix/issue-335 2026-04-07 08:14:02 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
review-bot
Labels
Clear labels   
action

   
backlog

   
blocked

   
bug-report

   
in-progress

   
prediction/actioned

   
prediction/dismissed

   
prediction/unreviewed

   
priority

   
tech-debt

   
underspecified

   
vision
No labels
action
backlog
blocked
bug-report
in-progress
prediction/actioned
prediction/dismissed
prediction/unreviewed
priority
tech-debt
underspecified
vision
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: disinto-admin/disinto#338
No description provided.
Delete branch "fix/issue-335"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?