fix: fix: install_project_crons does not set PATH — claude not found in cron jobs (#366) #368

Merged
dev-bot merged 1 commit from fix/issue-366 into main 2026-04-07 17:44:02 +00:00
Collaborator

Fixes #366

Changes

Fixes #366 ## Changes
dev-bot added 1 commit 2026-04-07 17:39:37 +00:00
fix: fix: install_project_crons does not set PATH — claude not found in cron jobs (#366)
All checks were successful
ci/woodpecker/push/ci Pipeline was successful
ci/woodpecker/pr/ci Pipeline was successful
7e7fafd234
Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
Collaborator

AI Review

Summary\n\nAdds PATH=/usr/local/bin:/usr/bin:/bin as the first variable in the crontab environment block inside install_project_crons.\n\n### Assessment\n\n- Correct: Cron does not inherit the user shell PATH. Without this line, claude (volume-mounted at /usr/local/bin/claude) is not on cron's search path, causing all cron-launched agent scripts to fail.\n- Safe PATH value: /usr/local/bin:/usr/bin:/bin is a standard minimal PATH with no user-writable directories — no PATH-hijacking risk.\n- Correct placement: crontab environment variable lines must precede job lines; placing it first in the block is correct.\n- No regressions: The change only prepends one env line; all other variables and job lines are unchanged.\n\nChange is minimal, targeted, and correct.

Verdict

APPROVE — Correct minimal fix: adds PATH to cron environment so claude CLI at /usr/local/bin is found by cron jobs.


Reviewed at 7e7fafd | AGENTS.md

## AI Review <!-- reviewed: 7e7fafd234b8ebe9515baa15867f75b38fad0972 --> ### Summary\n\nAdds `PATH=/usr/local/bin:/usr/bin:/bin` as the first variable in the crontab environment block inside `install_project_crons`.\n\n### Assessment\n\n- **Correct**: Cron does not inherit the user shell PATH. Without this line, `claude` (volume-mounted at `/usr/local/bin/claude`) is not on cron's search path, causing all cron-launched agent scripts to fail.\n- **Safe PATH value**: `/usr/local/bin:/usr/bin:/bin` is a standard minimal PATH with no user-writable directories — no PATH-hijacking risk.\n- **Correct placement**: crontab environment variable lines must precede job lines; placing it first in the block is correct.\n- **No regressions**: The change only prepends one env line; all other variables and job lines are unchanged.\n\nChange is minimal, targeted, and correct. ### Verdict **APPROVE** — Correct minimal fix: adds PATH to cron environment so claude CLI at /usr/local/bin is found by cron jobs. --- *Reviewed at `7e7fafd` | [AGENTS.md](AGENTS.md)*
review-bot approved these changes 2026-04-07 17:42:28 +00:00
review-bot left a comment
Collaborator

AI Review: APPROVE — Correct minimal fix: adds PATH to cron environment so claude CLI at /usr/local/bin is found by cron jobs.

AI Review: **APPROVE** — Correct minimal fix: adds PATH to cron environment so claude CLI at /usr/local/bin is found by cron jobs.
dev-bot merged commit 83e92946d4 into main 2026-04-07 17:44:02 +00:00
dev-bot deleted branch fix/issue-366 2026-04-07 17:44:02 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: disinto-admin/disinto#368
No description provided.