fix: dev-poll open-PR gate blocks all agents — should only block on own PRs #369

Closed
opened 2026-04-07 17:41:03 +00:00 by dev-bot · 0 comments
Collaborator

Problem

The #358 fix made the in-progress check per-agent ("their thread, not blocking"). But there is a second gate in dev-poll.sh: after checking in-progress issues, it checks if any in-progress issue has an open PR waiting for CI or review. If so, it exits without scanning the backlog.

This gate is still global — it blocks ALL agents when ANY agent has a PR pending review.

Observed: dev-qwen logs:

poll: issue #364 assigned to dev-bot — their thread, not blocking
poll: issue #364 has open PR #365 (CI: success, waiting)

Dev-qwen correctly skips the in-progress check but then hits the open-PR gate and stops.

Fix

Apply the same per-agent logic to the open-PR check. If an in-progress issue is assigned to a different agent, skip its PR check entirely:

if [ "$assignee" = "$me" ]; then
  # My issue — check its PR, block if waiting
  ...
else
  # Their issue — skip entirely (already logged above)
  continue
fi

The $me identity is already resolved earlier in the poll (from the #358 fix).

Affected files

  • dev/dev-poll.sh (open-PR check section, after the in-progress assignee check)

Acceptance criteria

  • Dev-qwen picks up backlog issues while dev-bot has a PR pending review
  • Each agent only blocks on its own open PRs
  • Two agents can have two separate PRs in review simultaneously
## Problem The #358 fix made the in-progress check per-agent ("their thread, not blocking"). But there is a second gate in dev-poll.sh: after checking in-progress issues, it checks if any in-progress issue has an open PR waiting for CI or review. If so, it exits without scanning the backlog. This gate is still global — it blocks ALL agents when ANY agent has a PR pending review. Observed: dev-qwen logs: poll: issue #364 assigned to dev-bot — their thread, not blocking poll: issue #364 has open PR #365 (CI: success, waiting) Dev-qwen correctly skips the in-progress check but then hits the open-PR gate and stops. ## Fix Apply the same per-agent logic to the open-PR check. If an in-progress issue is assigned to a different agent, skip its PR check entirely: if [ "$assignee" = "$me" ]; then # My issue — check its PR, block if waiting ... else # Their issue — skip entirely (already logged above) continue fi The $me identity is already resolved earlier in the poll (from the #358 fix). ## Affected files - dev/dev-poll.sh (open-PR check section, after the in-progress assignee check) ## Acceptance criteria - [ ] Dev-qwen picks up backlog issues while dev-bot has a PR pending review - [ ] Each agent only blocks on its own open PRs - [ ] Two agents can have two separate PRs in review simultaneously
dev-bot added the
backlog
priority
labels 2026-04-07 17:41:03 +00:00
dev-bot self-assigned this 2026-04-07 17:46:11 +00:00
dev-bot added
in-progress
and removed
backlog
labels 2026-04-07 17:46:12 +00:00
dev-bot removed their assignment 2026-04-07 17:54:03 +00:00
dev-bot removed the
in-progress
label 2026-04-07 17:54:03 +00:00
Sign in to join this conversation.
No milestone
No project
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: disinto-admin/disinto#369
No description provided.