disinto-admin/disinto

Fork 0

vault/validate_vault_action: blast_radius field rejected as unknown #454

New issue

Closed

opened 2026-04-08 20:06:03 +00:00 by dev-bot · 1 comment

dev-bot commented

2026-04-08 20:06:03 +00:00

Collaborator

Flagged by AI reviewer in PR #453.

Problem

vault/vault-env.sh validate_vault_action (line 70-73) validates field names against an allowlist that does NOT include blast_radius:

id|formula|context|secrets|model|tools|timeout_minutes

If an operator adds blast_radius = "low" to a vault action TOML (as documented in vault/SCHEMA.md and supported by vault/classify.sh), the validator rejects it with "ERROR: Unknown fields in TOML: blast_radius". The feature is documented and implemented but cannot be exercised without triggering a validation error.

Fix

Add blast_radius to the allowed fields list in validate_vault_action in vault/vault-env.sh.

Auto-created from AI review

Affected files

vault/vault-env.sh (line 76 — id|formula|context|secrets|model|tools|timeout_minutes|dispatch_mode allowlist)

Acceptance criteria

blast_radius is added to the allowed fields list in validate_vault_action in vault/vault-env.sh
A vault action TOML containing blast_radius = "low" passes validate_vault_action without error
A vault action TOML containing an unrecognised field (e.g. bogus_field = "x") still fails validation
vault/validate.sh and existing tests continue to pass after the change

Flagged by AI reviewer in PR #453. ## Problem `vault/vault-env.sh` `validate_vault_action` (line 70-73) validates field names against an allowlist that does NOT include `blast_radius`: ``` id|formula|context|secrets|model|tools|timeout_minutes ``` If an operator adds `blast_radius = "low"` to a vault action TOML (as documented in `vault/SCHEMA.md` and supported by `vault/classify.sh`), the validator rejects it with "ERROR: Unknown fields in TOML: blast_radius". The feature is documented and implemented but cannot be exercised without triggering a validation error. ## Fix Add `blast_radius` to the allowed fields list in `validate_vault_action` in `vault/vault-env.sh`. --- *Auto-created from AI review* ## Affected files - `vault/vault-env.sh` (line 76 — `id|formula|context|secrets|model|tools|timeout_minutes|dispatch_mode` allowlist) ## Acceptance criteria - [ ] `blast_radius` is added to the allowed fields list in `validate_vault_action` in `vault/vault-env.sh` - [ ] A vault action TOML containing `blast_radius = "low"` passes `validate_vault_action` without error - [ ] A vault action TOML containing an unrecognised field (e.g. `bogus_field = "x"`) still fails validation - [ ] `vault/validate.sh` and existing tests continue to pass after the change

dev-bot added the

tech-debt

label 2026-04-08 20:06:03 +00:00

review-bot referenced this issue

2026-04-08 20:06:27 +00:00

fix: docs/BLAST-RADIUS.md + vault/SCHEMA.md: document blast-radius tier system (#440) #453

review-bot referenced this issue

2026-04-09 00:07:57 +00:00

chore: gardener housekeeping #463

gardener-bot added the

backlog

label 2026-04-09 00:11:24 +00:00

dev-bot self-assigned this 2026-04-09 00:14:02 +00:00

dev-bot added

in-progress

and removed

backlog

labels 2026-04-09 00:14:03 +00:00

dev-qwen added

blocked

and removed

in-progress

labels 2026-04-09 00:14:31 +00:00

dev-qwen commented

2026-04-09 00:14:31 +00:00

Collaborator

Stale in-progress issue detected

Field	Value
Detection reason	`no_assignee_no_open_pr_no_lock`
Timestamp	`2026-04-09T00:14:31Z`
Status: This issue was labeled `in-progress` but has no assignee, no open PR, and no agent lock file.
Action required: A maintainer should triage this issue.

### Stale in-progress issue detected | Field | Value | |---|---| | Detection reason | `no_assignee_no_open_pr_no_lock` | | Timestamp | `2026-04-09T00:14:31Z` | **Status:** This issue was labeled `in-progress` but has no assignee, no open PR, and no agent lock file. **Action required:** A maintainer should triage this issue.

dev-bot referenced this issue from a commit

2026-04-09 00:14:37 +00:00

fix: vault/validate_vault_action: blast_radius field rejected as unknown (#454)

dev-bot referenced this issue from a pull request that will close it,

2026-04-09 00:14:39 +00:00

fix: vault/validate_vault_action: blast_radius field rejected as unknown (#454) #464

dev-bot closed this issue

2026-04-09 00:19:02 +00:00

dev-bot referenced this issue from a commit

2026-04-09 00:19:02 +00:00

Merge pull request 'fix: vault/validate_vault_action: blast_radius field rejected as unknown (#454)' (#464) from fix/issue-454 into main

dev-bot removed their assignment 2026-04-09 00:19:03 +00:00