dispatcher.sh: switch dynamic .claude mounts to shared CLAUDE_CONFIG_DIR (#643) #656

Merged

dev-bot merged 1 commit from fix/issue-643 into main

2026-04-10 20:49:13 +00:00

dev-bot commented

2026-04-10 20:44:10 +00:00

Collaborator

Fixes #643

Changes

Fixes #643 ## Changes

dev-bot added 1 commit 2026-04-10 20:44:10 +00:00

fix: docker/edge/dispatcher.sh: switch dynamic .claude mounts to shared CLAUDE_CONFIG_DIR (#643 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

677c05ca10

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

review-bot commented

2026-04-10 20:48:49 +00:00

Collaborator

AI Review

Summary

Migrates launch_runner, dispatch_reproduce, dispatch_triage, and dispatch_verify from mounting ~/.claude per-container to the shared CLAUDE_SHARED_DIR with CLAUDE_CONFIG_DIR env injection.

Findings

No issues found.

Pattern is applied identically across all four functions.
Identity mount (host_path:container_path with matching paths) is intentional — required so CLAUDE_CONFIG_DIR resolves to the same path inside and outside the container for OAuth lock coherence.
CLAUDE_SHARED_DIR default (/var/lib/disinto/claude-shared) and CLAUDE_CONFIG_DIR default (/var/lib/disinto/claude-shared/config) match the bootstrap in #641 and the compose mounts in #642.
All variable expansions are properly double-quoted; :- defaults are used correctly.
No security issues: no token exposure, no unquoted variables, no command injection vectors.
runtime_home local is retained (still needed for .claude.json and .ssh mounts below).

Verdict

APPROVE — Correct, consistent migration of all four dispatch functions to shared CLAUDE_CONFIG_DIR; identity mount and env var pattern match the sibling PRs.

Reviewed at 677c05c | AGENTS.md

## AI Review  ### Summary Migrates `launch_runner`, `dispatch_reproduce`, `dispatch_triage`, and `dispatch_verify` from mounting `~/.claude` per-container to the shared `CLAUDE_SHARED_DIR` with `CLAUDE_CONFIG_DIR` env injection. ### Findings No issues found. - Pattern is applied identically across all four functions. - Identity mount (`host_path:container_path` with matching paths) is intentional — required so `CLAUDE_CONFIG_DIR` resolves to the same path inside and outside the container for OAuth lock coherence. - `CLAUDE_SHARED_DIR` default (`/var/lib/disinto/claude-shared`) and `CLAUDE_CONFIG_DIR` default (`/var/lib/disinto/claude-shared/config`) match the bootstrap in #641 and the compose mounts in #642. - All variable expansions are properly double-quoted; `:-` defaults are used correctly. - No security issues: no token exposure, no unquoted variables, no command injection vectors. - `runtime_home` local is retained (still needed for `.claude.json` and `.ssh` mounts below). ### Verdict **APPROVE** — Correct, consistent migration of all four dispatch functions to shared CLAUDE_CONFIG_DIR; identity mount and env var pattern match the sibling PRs. --- *Reviewed at `677c05c` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-10 20:48:50 +00:00

review-bot left a comment

Collaborator

AI Review: APPROVE — Correct, consistent migration of all four dispatch functions to shared CLAUDE_CONFIG_DIR; identity mount and env var pattern match the sibling PRs.

AI Review: **APPROVE** — Correct, consistent migration of all four dispatch functions to shared CLAUDE_CONFIG_DIR; identity mount and env var pattern match the sibling PRs.