fix: [nomad-prep] P1 — run all 7 bot roles on llama backend (gates migration) (#801) #816
No reviewers
Labels
No labels
action
backlog
blocked
bug-report
cannot-reproduce
in-progress
in-triage
needs-triage
prediction/actioned
prediction/dismissed
prediction/unreviewed
priority
rejected
reproduced
tech-debt
underspecified
vision
No milestone
No project
No assignees
2 participants
Notifications
Due date
No due date set.
Dependencies
No dependencies set.
Reference: disinto-admin/disinto#816
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "fix/issue-801"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
Fixes #801
Changes
AI Review
Summary
The PR adds supervisor to the default AGENT_ROLES and introduces a new agents-llama-all compose service that runs all 7 bot roles against the llama backend. The goal (gating the Nomad migration on a full llama soak test) is clearly implemented.
Review
info
docker/agents/entrypoint.sh:39:init_state_dirstill only lists 6 agents (dev reviewer gardener architect planner predictor), not 7. This is safe becausestate/.supervisor-activeis committed to the repo and will be present afterbootstrap_factory_repoclones the live checkout — but the list is now stale documentation.info
docker-compose.yml:90/lib/generators.sh:agents-llama(AGENT_ROLES=dev) received aSUPERVISOR_INTERVALenv var that it will never use. Harmless noise.info
lib/generators.sh:497: The generatedagents-llama-alltemplate is missingPROJECT_TOML: projects/disinto.tomlthat the staticdocker-compose.ymlincludes at line 169. In practice this does not matter — agents set PROJECT_TOML from their CLI arg, andops-setup.shfalls back toOPS_REPO_ROOTwhich the entrypoint already exports — but there is a drift between the two files that could confuse a future reader.Architecture / Documentation
agents-llama-allrow. ✓Infrastructure Check
Compared
agents-llama-allagainstagentsandagents-llama:restart: unless-stoppedset. ✓security_opt: apparmor=unconfinedset. ✓ANTHROPIC_BASE_URLforwarded (required for llama routing). ✓depends_onincludes both forgejo (healthy) and woodpecker (started). ✓No dropped production configuration found.
Verdict
APPROVE — Supervisor correctly added as 7th default role; new agents-llama-all service is properly configured; scheduling logic matches existing patterns
Reviewed at
0bfa31d| AGENTS.mdAI Review: APPROVE — Supervisor correctly added as 7th default role; new agents-llama-all service is properly configured; scheduling logic matches existing patterns