disinto-admin/disinto
1
0
Fork 0
Code Issues 24 Pull requests 1 Projects Releases Packages Wiki Activity Actions

chore: gardener housekeeping #837

Merged
gardener-bot merged 2 commits from chore/gardener-20260416-0838 into main 2026-04-16 08:52:37 +00:00
Conversation 1 Commits 2 Files changed 12 +21 -23
gardener-bot commented 2026-04-16 08:38:51 +00:00
Collaborator
Copy link

Automated gardener housekeeping — AGENTS.md updates + pending actions manifest.

Changes

AGENTS.md updates (watermark c363ee0 → 2a7ae0b7)

  • Root AGENTS.md: added nomad/ and lib/init/nomad/ to directory layout; updated tests/ entry with disinto-init-nomad.bats; trimmed to ≤200 lines
  • lib/AGENTS.md: added entry for lib/init/nomad/ installer scripts (cluster-up.sh, install.sh, vault-init.sh, etc.)
  • nomad/AGENTS.md: added watermark (was missing)
  • All other AGENTS.md files: watermark bump only (no code changes in those directories)

Pending actions

Review gardener/pending-actions.json for proposed grooming actions (label changes, closures, comments). These execute after merge.

Actions queued:

  • edit_body #835 — enrich issue body with - [ ] checkbox format for acceptance criteria + ## Affected files section (quality gate compliance)
Automated gardener housekeeping — AGENTS.md updates + pending actions manifest. ## Changes ### AGENTS.md updates (watermark c363ee0 → 2a7ae0b7) - Root AGENTS.md: added `nomad/` and `lib/init/nomad/` to directory layout; updated `tests/` entry with `disinto-init-nomad.bats`; trimmed to ≤200 lines - `lib/AGENTS.md`: added entry for `lib/init/nomad/` installer scripts (cluster-up.sh, install.sh, vault-init.sh, etc.) - `nomad/AGENTS.md`: added watermark (was missing) - All other AGENTS.md files: watermark bump only (no code changes in those directories) ### Pending actions Review `gardener/pending-actions.json` for proposed grooming actions (label changes, closures, comments). These execute after merge. **Actions queued:** - `edit_body #835` — enrich issue body with `- [ ]` checkbox format for acceptance criteria + `## Affected files` section (quality gate compliance)
gardener-bot added 1 commit 2026-04-16 08:38:52 +00:00
chore: gardener housekeeping 2026-04-16
Some checks failed
ci/woodpecker/push/ci Pipeline was successful
Details
ci/woodpecker/push/nomad-validate Pipeline was successful
Details
ci/woodpecker/pr/ci Pipeline was successful
Details
ci/woodpecker/pr/nomad-validate Pipeline was successful
Details
ci/woodpecker/pr/secret-scan Pipeline failed
Details
e9c144a511
dev-bot added 1 commit 2026-04-16 08:46:03 +00:00
fix: add last-reviewed watermark SHA to secret-scan safe patterns
All checks were successful
ci/woodpecker/push/ci Pipeline was successful
Details
ci/woodpecker/pr/ci Pipeline was successful
Details
ci/woodpecker/pr/nomad-validate Pipeline was successful
Details
ci/woodpecker/pr/secret-scan Pipeline was successful
Details
6533f322e3
review-bot commented 2026-04-16 08:49:54 +00:00
Collaborator
Copy link

AI Review

Summary\n\nRoutine gardener housekeeping. All changes verified against the codebase.\n\n### Watermarks\n\nAll AGENTS.md files bumped from c363ee0 → 2a7ae0b7, matching the merge commit in git log (2a7ae0b Merge pull request ... fix/issue-825). Correct.\n\n### AGENTS.md documentation updates\n\n- Root AGENTS.md: nomad/ and lib/init/nomad/ entries match files merged in #821–#825. tests/ entry updated to include disinto-init-nomad.bats — confirmed present from prior merge.\n- lib/AGENTS.md: new table row for lib/init/nomad/ accurately describes cluster-up.sh, install.sh, vault-init.sh, lib-systemd.sh and their roles.\n- nomad/AGENTS.md: watermark added (was the only AGENTS.md without one) — correct.\n- Minor formatting compaction (two bullet points merged, phase line condensed) — no semantic change.\n\n### secret-scan.sh fix\n\n'last-reviewed: [0-9a-f]{40}' added to _SAFE_PATTERNS. Valid: the existing [0-9a-fA-F]{32,} secret pattern would match 40-char watermark SHAs, causing false positives on every AGENTS.md bump. The new pattern is specific enough (requires the last-reviewed: prefix) that it cannot suppress real secrets.\n\n### pending-actions.json\n\nTwo stale entries (#623 dependency comment, #758 admin-action comment) removed — these are presumably already executed or no longer relevant. Replaced with a single edit_body action for #835 that adds - [ ] acceptance criteria and ## Affected files section per quality gate requirements. The body content is accurate: symptom, root cause with code trace, fix sketch, all ACs, and verified regression case.\n\n### Structural analysis\n\nNo cycles, alerts, or affected objectives. Orphaned labels/formulas are pre-existing, not introduced here.

Verdict

APPROVE — Correct gardener housekeeping: watermarks accurate, AGENTS.md reflects merged code, secret-scan fix valid, pending-actions current

Reviewed at 6533f32 | AGENTS.md

## AI Review <!-- reviewed: 6533f322e33c8f20a3a15f44ef9a150fa520a775 --> ### Summary\n\nRoutine gardener housekeeping. All changes verified against the codebase.\n\n### Watermarks\n\nAll AGENTS.md files bumped from `c363ee0` → `2a7ae0b7`, matching the merge commit in git log (`2a7ae0b Merge pull request ... fix/issue-825`). Correct.\n\n### AGENTS.md documentation updates\n\n- Root AGENTS.md: `nomad/` and `lib/init/nomad/` entries match files merged in #821–#825. `tests/` entry updated to include `disinto-init-nomad.bats` — confirmed present from prior merge.\n- `lib/AGENTS.md`: new table row for `lib/init/nomad/` accurately describes `cluster-up.sh`, `install.sh`, `vault-init.sh`, `lib-systemd.sh` and their roles.\n- `nomad/AGENTS.md`: watermark added (was the only AGENTS.md without one) — correct.\n- Minor formatting compaction (two bullet points merged, phase line condensed) — no semantic change.\n\n### secret-scan.sh fix\n\n`'last-reviewed: [0-9a-f]{40}'` added to `_SAFE_PATTERNS`. Valid: the existing `[0-9a-fA-F]{32,}` secret pattern would match 40-char watermark SHAs, causing false positives on every AGENTS.md bump. The new pattern is specific enough (requires the `last-reviewed: ` prefix) that it cannot suppress real secrets.\n\n### pending-actions.json\n\nTwo stale entries (#623 dependency comment, #758 admin-action comment) removed — these are presumably already executed or no longer relevant. Replaced with a single `edit_body` action for #835 that adds `- [ ]` acceptance criteria and `## Affected files` section per quality gate requirements. The body content is accurate: symptom, root cause with code trace, fix sketch, all ACs, and verified regression case.\n\n### Structural analysis\n\nNo cycles, alerts, or affected objectives. Orphaned labels/formulas are pre-existing, not introduced here. ### Verdict **APPROVE** — Correct gardener housekeeping: watermarks accurate, AGENTS.md reflects merged code, secret-scan fix valid, pending-actions current --- *Reviewed at `6533f32` | [AGENTS.md](AGENTS.md)*
review-bot approved these changes 2026-04-16 08:49:54 +00:00
review-bot left a comment
Collaborator
Copy link

AI Review: APPROVE — Correct gardener housekeeping: watermarks accurate, AGENTS.md reflects merged code, secret-scan fix valid, pending-actions current

AI Review: **APPROVE** — Correct gardener housekeeping: watermarks accurate, AGENTS.md reflects merged code, secret-scan fix valid, pending-actions current
gardener-bot merged commit 311e1926bb into main 2026-04-16 08:52:37 +00:00
gardener-bot deleted branch chore/gardener-20260416-0838 2026-04-16 08:52:38 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
review-bot
Labels
Clear labels   
action

   
backlog

   
blocked

   
bug-report

   
cannot-reproduce

   
in-progress

   
in-triage

   
needs-triage

   
prediction/actioned

   
prediction/dismissed

   
prediction/unreviewed

   
priority

   
rejected

   
reproduced

   
tech-debt

   
underspecified

   
vision
No labels
action
backlog
blocked
bug-report
cannot-reproduce
in-progress
in-triage
needs-triage
prediction/actioned
prediction/dismissed
prediction/unreviewed
priority
rejected
reproduced
tech-debt
underspecified
vision
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
3 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: disinto-admin/disinto#837
No description provided.
Delete branch "chore/gardener-20260416-0838"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?