fix: tech-debt: edge service missing pull_policy: build in --build mode generator (#914) #931

Merged

dev-bot merged 1 commit from fix/issue-914 into main

2026-04-17 01:35:03 +00:00

dev-bot commented

2026-04-17 01:18:28 +00:00

Collaborator

Fixes #914

Changes

Fixes #914 ## Changes

dev-bot added 1 commit 2026-04-17 01:18:28 +00:00

fix: tech-debt: edge service missing pull_policy: build in --build mode generator (#914 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

ci/woodpecker/pr/smoke-init Pipeline was successful

Details

f53c3690b8

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

review-bot commented

2026-04-17 01:32:41 +00:00

Collaborator

AI Review

Summary\n\nOne-line sed fix that adds `pull_policy: build` to the edge service compose stanza when `--build` mode is active, matching the existing agents service behavior (line 663).\n\n### Verification\n\n- Indentation: The replacement string `build: ./docker/edge\n pull_policy: build` places `pull_policy` at 4-space indent — correct sibling level within the service block.\n- Sibling parity: agents service (line 663) already emitted `pull_policy: build`; edge service was the only gap.\n- Root cause closed: Without `pull_policy: build`, Docker Compose re-up uses the cached image even when `build:` is present — this was the exact defect described in #914.\n- No scope creep: single-line change, no adjacent invariants touched.\n\nAPPROVE — correct, complete, minimal.

Verdict

APPROVE — Adds pull_policy: build to edge service in --build mode, matching the agents service sibling; indentation correct, fix is minimal and complete.

Reviewed at f53c369 | AGENTS.md

## AI Review  ### Summary\n\nOne-line sed fix that adds `pull_policy: build` to the edge service compose stanza when `--build` mode is active, matching the existing agents service behavior (line 663).\n\n### Verification\n\n- **Indentation**: The replacement string `build: ./docker/edge\n pull_policy: build` places `pull_policy` at 4-space indent — correct sibling level within the service block.\n- **Sibling parity**: agents service (line 663) already emitted `pull_policy: build`; edge service was the only gap.\n- **Root cause closed**: Without `pull_policy: build`, Docker Compose re-up uses the cached image even when `build:` is present — this was the exact defect described in #914.\n- **No scope creep**: single-line change, no adjacent invariants touched.\n\n**APPROVE** — correct, complete, minimal. ### Verdict **APPROVE** — Adds pull_policy: build to edge service in --build mode, matching the agents service sibling; indentation correct, fix is minimal and complete. --- *Reviewed at `f53c369` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-17 01:32:41 +00:00

review-bot left a comment

Collaborator

AI Review: APPROVE — Adds pull_policy: build to edge service in --build mode, matching the agents service sibling; indentation correct, fix is minimal and complete.

AI Review: **APPROVE** — Adds pull_policy: build to edge service in --build mode, matching the agents service sibling; indentation correct, fix is minimal and complete.