tech-debt: init --dry-run shows batch seed→deploy but real run is interleaved #950

New issue

Closed

opened 2026-04-17 08:37:59 +00:00 by dev-bot · 0 comments

dev-bot commented

2026-04-17 08:37:59 +00:00

Collaborator

Flagged by AI reviewer in PR #949.

Problem

After PR #949 the real run path in _disinto_init_nomad interleaves seed+deploy per service (seed-forgejo → deploy-forgejo → seed-woodpecker → deploy-woodpecker-…). However the dry-run preview block (bin/disinto ~lines 785–839) still displays the old batch pattern: all seeds listed first, then all deploys.

Before #949 both paths were consistent. Now dry-run output misrepresents what will actually execute, which can mislead operators planning or auditing a run.

Fix

Update the dry-run block to emit one "[dry-run] seed X → deploy X" pair per service in canonical order, matching the real-run interleaved sequence.

Auto-created from AI review

Affected files

bin/disinto (dry-run preview block, ~lines 785–839)

Acceptance criteria

disinto init --dry-run output shows one [dry-run] seed X → deploy X pair per service, in canonical order
Dry-run output matches the real-run execution order from _disinto_init_nomad
No behavior change to real run path
shellcheck clean
CI green

Flagged by AI reviewer in PR #949. ## Problem After PR #949 the real run path in `_disinto_init_nomad` interleaves seed+deploy per service (seed-forgejo → deploy-forgejo → seed-woodpecker → deploy-woodpecker-…). However the dry-run preview block (`bin/disinto` ~lines 785–839) still displays the old batch pattern: all seeds listed first, then all deploys. Before #949 both paths were consistent. Now dry-run output misrepresents what will actually execute, which can mislead operators planning or auditing a run. ## Fix Update the dry-run block to emit one "[dry-run] seed X → deploy X" pair per service in canonical order, matching the real-run interleaved sequence. *Auto-created from AI review* ## Affected files - `bin/disinto` (dry-run preview block, ~lines 785–839) ## Acceptance criteria - [ ] `disinto init --dry-run` output shows one `[dry-run] seed X → deploy X` pair per service, in canonical order - [ ] Dry-run output matches the real-run execution order from `_disinto_init_nomad` - [ ] No behavior change to real run path - [ ] `shellcheck` clean - [ ] CI green