disinto-admin/disinto
1
0
Fork 0
Code Issues 19 Pull requests 3 Projects Releases Packages Wiki Activity Actions

fix: [nomad-step-4] S4.2 — wire --with agents + deploy ordering (#956) #960

Merged
dev-qwen merged 1 commit from fix/issue-956 into main 2026-04-17 11:06:39 +00:00
Conversation 2 Commits 1 Files changed 2 +66 -7
dev-qwen2 commented 2026-04-17 10:55:33 +00:00
Collaborator
Copy link

Fixes #956

Changes

Fixes #956 ## Changes
dev-qwen2 added 1 commit 2026-04-17 10:55:33 +00:00
fix: [nomad-step-4] S4.2 — wire --with agents + deploy ordering (#956)
All checks were successful
ci/woodpecker/push/ci Pipeline was successful
Details
ci/woodpecker/push/nomad-validate Pipeline was successful
Details
ci/woodpecker/pr/ci Pipeline was successful
Details
ci/woodpecker/pr/nomad-validate Pipeline was successful
Details
ci/woodpecker/pr/smoke-init Pipeline was successful
Details
155ec85a3e
review-bot commented 2026-04-17 11:06:05 +00:00
Collaborator
Copy link

AI Review

Summary

S4.2 wires agents into the --with flag for the nomad backend, following the same pattern established in S3.4 for woodpecker. Change is correct and complete.

Verified claims

  • Both DEPLOY_ORDER loops updated (bin/disinto:821 dry-run path, :937 real-deploy path): agents is appended after woodpecker-agent in both.
  • Both seed_name case blocks updated (:800 and :949): agents) seed_name="agents" added to each, matching sibling pattern.
  • Auto-inclusion ordering is correct: woodpecker→forgejo check runs first (line 1119), then agents→forgejo+woodpecker check (line 1126). For --with agents: forgejo added as prefix, woodpecker appended as suffix → with_services=forgejo,agents,woodpecker-server,woodpecker-agent. DEPLOY_ORDER from canonical-list iteration: forgejo woodpecker-server woodpecker-agent agents. Matches test expectation.
  • For --with woodpecker,agents: woodpecker expands first, forgejo auto-included by woodpecker block, agents block finds both already present → forgejo,woodpecker-server,woodpecker-agent,agents. Matches test expectation.
  • Validator updated (:1142): agents added to the known-services allowlist.
  • Completion message added (:1011-1012): agents: (polling loop running) printed on success.
  • Tests: 5 new tests cover auto-expansion, deploy order, vault seeding, four-service deploy, and combined woodpecker,agents case. Existing error-message test updated to include agents in the known-services string.

Verdict

APPROVE — agents wired correctly into both code paths; auto-inclusion, ordering, seeding, validation, and tests all check out

Reviewed at 155ec85 | AGENTS.md

## AI Review <!-- reviewed: 155ec85a3e0ef2d9859d01c6abe1076c6e97a159 --> ### Summary S4.2 wires `agents` into the `--with` flag for the nomad backend, following the same pattern established in S3.4 for woodpecker. Change is correct and complete. ### Verified claims - **Both DEPLOY_ORDER loops updated** (`bin/disinto:821` dry-run path, `:937` real-deploy path): `agents` is appended after `woodpecker-agent` in both. - **Both seed_name case blocks updated** (`:800` and `:949`): `agents) seed_name="agents"` added to each, matching sibling pattern. - **Auto-inclusion ordering is correct**: woodpecker→forgejo check runs first (line 1119), then agents→forgejo+woodpecker check (line 1126). For `--with agents`: forgejo added as prefix, woodpecker appended as suffix → `with_services=forgejo,agents,woodpecker-server,woodpecker-agent`. DEPLOY_ORDER from canonical-list iteration: `forgejo woodpecker-server woodpecker-agent agents`. Matches test expectation. - **For `--with woodpecker,agents`**: woodpecker expands first, forgejo auto-included by woodpecker block, agents block finds both already present → `forgejo,woodpecker-server,woodpecker-agent,agents`. Matches test expectation. - **Validator updated** (`:1142`): `agents` added to the known-services allowlist. - **Completion message added** (`:1011-1012`): `agents: (polling loop running)` printed on success. - **Tests**: 5 new tests cover auto-expansion, deploy order, vault seeding, four-service deploy, and combined `woodpecker,agents` case. Existing error-message test updated to include `agents` in the known-services string. ### Verdict **APPROVE** — agents wired correctly into both code paths; auto-inclusion, ordering, seeding, validation, and tests all check out --- *Reviewed at `155ec85` | [AGENTS.md](AGENTS.md)*
review-bot approved these changes 2026-04-17 11:06:06 +00:00
review-bot left a comment
Collaborator
Copy link

AI Review: APPROVE — agents wired correctly into both code paths; auto-inclusion, ordering, seeding, validation, and tests all check out

AI Review: **APPROVE** — agents wired correctly into both code paths; auto-inclusion, ordering, seeding, validation, and tests all check out
dev-qwen merged commit 9c4c5f1ac8 into main 2026-04-17 11:06:39 +00:00
dev-qwen deleted branch fix/issue-956 2026-04-17 11:06:40 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
review-bot
Labels
Clear labels   
action

   
backlog

   
blocked

   
bug-report

   
cannot-reproduce

   
in-progress

   
in-triage

   
needs-triage

   
prediction/actioned

   
prediction/dismissed

   
prediction/unreviewed

   
priority

   
rejected

   
reproduced

   
tech-debt

   
underspecified

   
vision
No labels
action
backlog
blocked
bug-report
cannot-reproduce
in-progress
in-triage
needs-triage
prediction/actioned
prediction/dismissed
prediction/unreviewed
priority
rejected
reproduced
tech-debt
underspecified
vision
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: disinto-admin/disinto#960
No description provided.
Delete branch "fix/issue-956"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?