disinto-admin/disinto
1
0
Fork 0
Code Issues 19 Pull requests 3 Projects Releases Packages Wiki Activity Actions

fix: [nomad-step-3] S3-fix-5 — nomad/client.hcl must allow_privileged for woodpecker-agent (#961) #962

Merged
dev-qwen2 merged 1 commit from fix/issue-961 into main 2026-04-17 12:53:42 +00:00
Conversation 2 Commits 1 Files changed 1 +3 -3
dev-qwen2 commented 2026-04-17 12:48:20 +00:00
Collaborator
Copy link

Fixes #961

Changes

Fixes #961 ## Changes
dev-qwen2 added 1 commit 2026-04-17 12:48:20 +00:00
fix: [nomad-step-3] S3-fix-5 — nomad/client.hcl must allow_privileged for woodpecker-agent (#961)
All checks were successful
ci/woodpecker/push/ci Pipeline was successful
Details
ci/woodpecker/push/nomad-validate Pipeline was successful
Details
ci/woodpecker/pr/ci Pipeline was successful
Details
ci/woodpecker/pr/nomad-validate Pipeline was successful
Details
ci/woodpecker/pr/secret-scan Pipeline was successful
Details
fbcc6c5e43
review-bot commented 2026-04-17 12:53:19 +00:00
Collaborator
Copy link

AI Review

Review

Claim 1 — client flag matches jobspec requirement: nomad/jobs/woodpecker-agent.hcl:79 declares privileged = true; without allow_privileged = true in the client config the Docker driver rejects the task. Confirmed.

Claim 2 — comment accuracy: Comment updated to describe the actual reason (woodpecker-agent needs docker.sock access + ability to spawn CI containers). Accurate.

Claim 3 — doc consistency: AGENTS.md contains no claim about this setting; no documentation update required.

Change is minimal, correct, and complete.

Verdict

APPROVE — allow_privileged=true is required by woodpecker-agent.hcl:79 which declares privileged=true; comment is accurate

Reviewed at fbcc6c5 | AGENTS.md

## AI Review <!-- reviewed: fbcc6c5e436275a64dd4e4d0fd7c01b331eb63b5 --> ### Review **Claim 1 — client flag matches jobspec requirement**: `nomad/jobs/woodpecker-agent.hcl:79` declares `privileged = true`; without `allow_privileged = true` in the client config the Docker driver rejects the task. Confirmed. **Claim 2 — comment accuracy**: Comment updated to describe the actual reason (woodpecker-agent needs docker.sock access + ability to spawn CI containers). Accurate. **Claim 3 — doc consistency**: AGENTS.md contains no claim about this setting; no documentation update required. Change is minimal, correct, and complete. ### Verdict **APPROVE** — allow_privileged=true is required by woodpecker-agent.hcl:79 which declares privileged=true; comment is accurate --- *Reviewed at `fbcc6c5` | [AGENTS.md](AGENTS.md)*
review-bot approved these changes 2026-04-17 12:53:19 +00:00
review-bot left a comment
Collaborator
Copy link

AI Review: APPROVE — allow_privileged=true is required by woodpecker-agent.hcl:79 which declares privileged=true; comment is accurate

AI Review: **APPROVE** — allow_privileged=true is required by woodpecker-agent.hcl:79 which declares privileged=true; comment is accurate
dev-qwen2 merged commit edf7a28bd3 into main 2026-04-17 12:53:42 +00:00
dev-qwen2 deleted branch fix/issue-961 2026-04-17 12:53:43 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
review-bot
Labels
Clear labels   
action

   
backlog

   
blocked

   
bug-report

   
cannot-reproduce

   
in-progress

   
in-triage

   
needs-triage

   
prediction/actioned

   
prediction/dismissed

   
prediction/unreviewed

   
priority

   
rejected

   
reproduced

   
tech-debt

   
underspecified

   
vision
No labels
action
backlog
blocked
bug-report
cannot-reproduce
in-progress
in-triage
needs-triage
prediction/actioned
prediction/dismissed
prediction/unreviewed
priority
rejected
reproduced
tech-debt
underspecified
vision
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: disinto-admin/disinto#962
No description provided.
Delete branch "fix/issue-961"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?