fix: [nomad-step-4] S4-fix-5 — agents.hcl needs force_pull=false for locally-built image (#978) #979

Merged
dev-qwen merged 1 commit from fix/issue-978 into main 2026-04-17 17:02:18 +00:00
Collaborator

Fixes #978

Changes

Fixes #978 ## Changes
dev-qwen added 1 commit 2026-04-17 16:57:59 +00:00
fix: [nomad-step-4] S4-fix-5 — agents.hcl needs force_pull=false for locally-built image (#978)
All checks were successful
ci/woodpecker/push/ci Pipeline was successful
ci/woodpecker/push/nomad-validate Pipeline was successful
ci/woodpecker/pr/ci Pipeline was successful
ci/woodpecker/pr/nomad-validate Pipeline was successful
ci/woodpecker/pr/secret-scan Pipeline was successful
ffd1f41b33
Collaborator

AI Review

Summary

Single-line config fix: adds force_pull = false to the Nomad Docker driver stanza so Nomad won't attempt a registry pull for disinto/agents:latest, which is built locally and never pushed to a registry.

Correctness claims

  1. Key nameforce_pull is the correct Nomad Docker driver config key (not imagePullPolicy or similar). Confirmed correct.
  2. Valuefalse prevents Nomad from pulling; without this, Nomad defaults to pulling (or attempts it depending on version), which fails for local-only images. Correct fix.
  3. Scope — diff touches only the config {} stanza, adding one line and aligning the image = key. No volumes, env vars, Vault templates, or restart policy touched.
  4. No regressions — all surrounding stanzas (security_opt, volume mounts, env, template, resources) are intact in the post-merge file.

All four claims verified. Change is correct and complete.

Verdict

APPROVE — force_pull = false is correct for a locally-built image; change is minimal, correct, and complete


Reviewed at ffd1f41 | AGENTS.md

## AI Review <!-- reviewed: ffd1f41b33a42f2b2b857adf380e952c1b5b5519 --> ### Summary Single-line config fix: adds `force_pull = false` to the Nomad Docker driver stanza so Nomad won't attempt a registry pull for `disinto/agents:latest`, which is built locally and never pushed to a registry. ### Correctness claims 1. **Key name** — `force_pull` is the correct Nomad Docker driver config key (not `imagePullPolicy` or similar). Confirmed correct. 2. **Value** — `false` prevents Nomad from pulling; without this, Nomad defaults to pulling (or attempts it depending on version), which fails for local-only images. Correct fix. 3. **Scope** — diff touches only the `config {}` stanza, adding one line and aligning the `image =` key. No volumes, env vars, Vault templates, or restart policy touched. 4. **No regressions** — all surrounding stanzas (security_opt, volume mounts, env, template, resources) are intact in the post-merge file. All four claims verified. Change is correct and complete. ### Verdict **APPROVE** — force_pull = false is correct for a locally-built image; change is minimal, correct, and complete --- *Reviewed at `ffd1f41` | [AGENTS.md](AGENTS.md)*
review-bot approved these changes 2026-04-17 17:02:04 +00:00
review-bot left a comment
Collaborator

AI Review: APPROVE — force_pull = false is correct for a locally-built image; change is minimal, correct, and complete

AI Review: **APPROVE** — force_pull = false is correct for a locally-built image; change is minimal, correct, and complete
dev-qwen merged commit 71e770b8ae into main 2026-04-17 17:02:18 +00:00
dev-qwen deleted branch fix/issue-978 2026-04-17 17:02:19 +00:00
Sign in to join this conversation.
No reviewers
No milestone
No project
No assignees
2 participants
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: disinto-admin/disinto#979
No description provided.