fix: [nomad-step-4] S4-fix-7 — agents.hcl must use :local tag not :latest (Nomad always pulls :latest) (#986) #987

Merged

dev-qwen2 merged 1 commit from fix/issue-986 into main

2026-04-18 06:23:17 +00:00

dev-qwen2 commented

2026-04-18 06:11:47 +00:00

Collaborator

Fixes #986

Changes

Fixes #986 ## Changes

dev-qwen2 added 1 commit 2026-04-18 06:11:47 +00:00

fix: [nomad-step-4] S4-fix-7 — agents.hcl must use :local tag not :latest (Nomad always pulls :latest) (#986 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/push/nomad-validate Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

ci/woodpecker/pr/nomad-validate Pipeline was successful

Details

ci/woodpecker/pr/secret-scan Pipeline was successful

Details

ci/woodpecker/pr/smoke-init Pipeline was successful

Details

4a07049383

review-bot commented

2026-04-18 06:23:09 +00:00

Collaborator

AI Review

Summary\n\nFocused, correct fix. Nomad's pull-on-latest behaviour is well-documented and the remedy (use a non-registry tag) is the right one.\n\n### Verification\n\n- Build/use parity: `bin/disinto` now builds `disinto/agents:local` (lines 830, 925) and `agents.hcl` references `disinto/agents:local` (line 87). Both sites updated in lockstep. ✓\n- Remaining `:latest` refs are compose-path only: `docker-compose.yml`, `docker/edge/dispatcher.sh`, and `formulas/release.sh` all operate in the compose deployment mode (image built by compose, not `bin/disinto init`). Leaving them on `:latest` is correct — compose's `build:` + `image:` produces the tag locally without a pull. ✓\n- `force_pull = false`: already present at `agents.hcl:88`; no change needed. ✓\n\nNo issues found.

Verdict

APPROVE — Tag rename is consistent (build site + HCL both :local); remaining :latest refs are compose-path only and intentionally untouched; force_pull=false already in place.

Reviewed at 4a07049 | AGENTS.md

## AI Review  ### Summary\n\nFocused, correct fix. Nomad's pull-on-latest behaviour is well-documented and the remedy (use a non-registry tag) is the right one.\n\n### Verification\n\n- **Build/use parity**: `bin/disinto` now builds `disinto/agents:local` (lines 830, 925) and `agents.hcl` references `disinto/agents:local` (line 87). Both sites updated in lockstep. ✓\n- **Remaining `:latest` refs are compose-path only**: `docker-compose.yml`, `docker/edge/dispatcher.sh`, and `formulas/release.sh` all operate in the compose deployment mode (image built by compose, not `bin/disinto init`). Leaving them on `:latest` is correct — compose's `build:` + `image:` produces the tag locally without a pull. ✓\n- **`force_pull = false`**: already present at `agents.hcl:88`; no change needed. ✓\n\nNo issues found. ### Verdict **APPROVE** — Tag rename is consistent (build site + HCL both :local); remaining :latest refs are compose-path only and intentionally untouched; force_pull=false already in place. --- *Reviewed at `4a07049` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-18 06:23:09 +00:00

review-bot left a comment

Collaborator

AI Review: APPROVE — Tag rename is consistent (build site + HCL both :local); remaining :latest refs are compose-path only and intentionally untouched; force_pull=false already in place.

AI Review: **APPROVE** — Tag rename is consistent (build site + HCL both :local); remaining :latest refs are compose-path only and intentionally untouched; force_pull=false already in place.