26 lines
7.5 KiB
JSON
26 lines
7.5 KiB
JSON
[
|
|
{
|
|
"action": "edit_body",
|
|
"issue": 765,
|
|
"body": "## Problem\nPlanner phase 5 pushes ops repo changes directly to `main` (`planner/AGENTS.md:37`, `planner/planner-run.sh`). Branch protection blocks this — see #758 for the symptom (PR #30 stuck, ops `main` frozen at v0.2.0 since 2026-04-08).\n\n## Why a new issue\n#758 is assigned to dev-qwen and labelled blocked; this reframes the fix rather than the symptom.\n\n## Proposal\nFold planner into the same flow architect already uses for ops PRs (`pr_create` → `pr_walk_to_merge` against `FORGE_OPS_REPO`). Architect proves merge perms work; review-bot already gates ops PRs and decides auto-approve vs request-changes. No new reviewer, no permission changes.\n\n## Changes\n- `planner/planner-run.sh` phase 5: stop direct push; create branch `planner/run-YYYY-MM-DD`, call `pr_create` then `pr_walk_to_merge`.\n- Planner formula prompt: replace \"push directly\" instructions with phase-protocol terminology used by architect.\n- `planner/AGENTS.md`: update phase 5 description.\n\n## Acceptance\n- Planner run produces a PR on ops repo, walks to merged via review-bot.\n- PR #30 closed (superseded) once new flow lands.\n- ops `main` advances past v0.2.0.\n\n## Acceptance criteria\n- [ ] Planner run produces a PR on ops repo, walks to merged via review-bot\n- [ ] PR #30 closed (superseded) once new flow lands\n- [ ] ops `main` advances past v0.2.0\n- [ ] CI green on the planner changes\n\n## Affected files\n- `planner/planner-run.sh` — replace direct push with `pr_create` + `pr_walk_to_merge`\n- `planner/AGENTS.md` — update phase 5 description"
|
|
},
|
|
{
|
|
"action": "edit_body",
|
|
"issue": 429,
|
|
"body": "## Problem\n\nThe generated docker-compose.yml uses `build: context: . dockerfile: docker/agents/Dockerfile` which bakes the disinto code into the image via `COPY . /home/agent/disinto`. This causes:\n\n1. **Read-only code** — runtime state (`state/`), config (`projects/*.toml`), and `.env` are not in the image, but the baked-in directory is read-only. Manual volume mount workarounds break on every compose regeneration.\n2. **No versioning** — every `docker compose build` creates a new image from whatever code is on disk. No way to pin a known-good version or roll back.\n3. **No distribution** — new factory instances must clone the disinto repo and build locally. Cannot just `docker pull` and run.\n4. **Fragile rebuilds** — `docker system prune` removes the locally-built image, requiring a full rebuild that may fail (wrong Dockerfile, missing deps, stale cache).\n\n## Proposed solution: publish versioned images\n\nPublish container images to a registry (e.g. `ghcr.io/disinto/agents:v0.1.0`) on each release. The generated compose uses `image:` instead of `build:`.\n\n### Image structure\n\n```\ndisinto-agents:v0.1.0\n /home/agent/disinto/ # code (immutable, from COPY at build)\n /home/agent/data/ # VOLUME — runtime state, logs\n /home/agent/repos/ # VOLUME — project repos\n```\n\n### Runtime mounts (compose volumes)\n\n```yaml\nagents:\n image: ghcr.io/disinto/agents:v0.1.0\n volumes:\n - agent-data:/home/agent/data # logs, locks, state\n - project-repos:/home/agent/repos # cloned project repos\n - ./projects:/home/agent/disinto/projects:ro # project TOMLs\n - ./.env:/home/agent/disinto/.env:ro # tokens, config\n - ./state:/home/agent/disinto/state # agent activation markers\n - ~/.claude:/home/agent/.claude # Claude credentials\n - ~/.claude.json:/home/agent/.claude.json:ro\n - <claude-cli>:/usr/local/bin/claude:ro\n```\n\n### What changes\n\n- `bin/disinto init` generates compose with `image: ghcr.io/disinto/agents:<version>` instead of `build:`\n- CI pipeline (Woodpecker) builds + pushes images on tag/release\n- `disinto release` updates the image tag in the compose template\n- Same for edge, reproduce, and any other disinto containers\n- `state/` directory must be a writable mount point, not baked into the image\n\n### Images to publish\n\n| Image | Purpose |\n|-------|----------|\n| `disinto/agents` | Dev, review, gardener, planner, predictor, architect agents |\n| `disinto/reproduce` | Reproduce + triage sidecar (Playwright, Docker CLI) |\n| `disinto/edge` | Caddy reverse proxy + dispatcher |\n\n### Backwards compatibility\n\n- `disinto init --build` flag for dev mode (local build, same as today)\n- Default: `image:` from registry\n- Existing deployments: migration guide to switch from build to image\n\n## Files\n\n- `bin/disinto` — `generate_compose()` to emit `image:` instead of `build:`\n- New: CI pipeline for building + pushing images\n- New: `bin/disinto release` updates image tags\n- `docker/agents/Dockerfile` — declare VOLUME mount points explicitly\n- `docker/reproduce/Dockerfile` — same\n- `docker/edge/Dockerfile` — same\n\n## Acceptance criteria\n- [ ] CI pipeline builds and pushes `disinto/agents` image on tag/release\n- [ ] CI pipeline builds and pushes `disinto/reproduce` image on tag/release\n- [ ] CI pipeline builds and pushes `disinto/edge` image on tag/release\n- [ ] `bin/disinto init` generates compose with `image:` instead of `build:`\n- [ ] `bin/disinto init --build` flag enables local build mode for dev\n- [ ] `docker/agents/Dockerfile` declares VOLUME mount points explicitly\n- [ ] `docker/reproduce/Dockerfile` declares VOLUME mount points\n- [ ] `docker/edge/Dockerfile` declares VOLUME mount points\n\n## Affected files\n- `bin/disinto` — `generate_compose()` to emit `image:` instead of `build:`\n- `docker/agents/Dockerfile` — declare VOLUME mount points\n- `docker/reproduce/Dockerfile` — declare VOLUME mount points\n- `docker/edge/Dockerfile` — declare VOLUME mount points\n- `.woodpecker/` — new CI pipeline for building and pushing images"
|
|
},
|
|
{
|
|
"action": "add_label",
|
|
"issue": 429,
|
|
"label": "backlog"
|
|
},
|
|
{
|
|
"action": "create_issue",
|
|
"title": "fix: vault_request RETURN trap fires prematurely when vault-env.sh is sourced",
|
|
"body": "## Problem\n\n`vault_request()` in `lib/vault.sh` uses `trap ... RETURN` to clean up its temp TOML file. However, when `vault-env.sh` is sourced inside the function (as part of validation), bash fires RETURN traps for each function call made during the source. This causes the temp file to be deleted before `validate_vault_action` reads it.\n\n## Repro\n\n```bash\nsource lib/env.sh\nsource lib/vault.sh\nsource lib/pr-lifecycle.sh\nvault_request \"test-id\" \"id = \\\"test\\\"\\nformula = \\\"run-rent-a-human\\\"\\ncontext = \\\"test\\\"\\nsecrets = []\"\n# => ERROR: File not found: /tmp/vault-XXXX.toml\n# => ERROR: TOML validation failed\n```\n\n## Root cause\n\n```bash\n# In vault_request:\ntmp_toml=$(mktemp /tmp/vault-XXXXXX.toml)\ntrap 'rm -f \"$tmp_toml\"' RETURN # <-- fires on source, not just on return\n\n# Later:\nsource \"$vault_env\" # <-- RETURN trap fires here, deleting tmp_toml\nvalidate_vault_action \"$tmp_toml\" # <-- file is gone\n```\n\n## Fix\n\nUse `EXIT` trap instead of `RETURN`, or set the trap AFTER sourcing vault-env.sh.\n\n```bash\n# Option A: trap on EXIT instead\ntrap 'rm -f \"$tmp_toml\"' EXIT\n\n# Option B: source first, set trap after \nsource \"$vault_env\"\ntrap 'rm -f \"$tmp_toml\"' RETURN\n```\n\n## Acceptance criteria\n- [ ] `vault_request` successfully validates TOML without \"File not found\" error\n- [ ] Temp file is still cleaned up after function returns\n- [ ] Existing vault test (if any) passes\n\n## Affected files\n- `lib/vault.sh` — fix `trap ... RETURN` in `vault_request()`",
|
|
"labels": [
|
|
"backlog",
|
|
"bug-report"
|
|
]
|
|
}
|
|
]
|