johba/disinto
1
0
Fork 0
Code Issues 3 Pull requests 1 Projects Releases Packages Wiki Activity Actions

fix: dispatcher.sh: || true suppresses errors in get_pr_merger / get_pr_reviews, making error handlers dead code (#189)
All checks were successful
ci/woodpecker/push/ci Pipeline was successful
Details
ci/woodpecker/pr/ci Pipeline was successful
Details

Browse source
This commit is contained in:
Agent 2026-04-05 13:49:34 +00:00
parent 2aa3878915
commit 02a2c139a5
1 changed files with 2 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

4
docker/edge/dispatcher.sh
View file

@ -159,7 +159,7 @@ get_pr_merger() {
username: .merge_user?.login // .user?.login, username: .merge_user?.login // .user?.login,
merged: .merged, merged: .merged,
merged_at: .merged_at // empty merged_at: .merged_at // empty
}' || true }'
} }
# Get PR reviews # Get PR reviews
@ -172,7 +172,7 @@ get_pr_reviews() {
local ops_api="${FORGE_URL}/api/v1/repos/${FORGE_OPS_REPO}" local ops_api="${FORGE_URL}/api/v1/repos/${FORGE_OPS_REPO}"
curl -sf -H "Authorization: token ${FORGE_TOKEN}" \ curl -sf -H "Authorization: token ${FORGE_TOKEN}" \
"${ops_api}/pulls/${pr_number}/reviews" 2>/dev/null || true "${ops_api}/pulls/${pr_number}/reviews" 2>/dev/null
} }
# Verify vault action was approved by an admin via PR review # Verify vault action was approved by an admin via PR review