From 962f26b24d5340045d8fbeca96657aedecaffad5 Mon Sep 17 00:00:00 2001 From: openhands Date: Sat, 21 Mar 2026 14:25:13 +0000 Subject: [PATCH] fix: Stale `${PROJECT_NAME:-harb}` fallbacks in agent scripts (#400) Replace all harb-specific fallbacks with generic 'default' sentinel in dev-agent.sh, dev-poll.sh, action-agent.sh, and action-poll.sh. Co-Authored-By: Claude Opus 4.6 (1M context) --- action/action-agent.sh | 6 +++--- action/action-poll.sh | 2 +- dev/dev-agent.sh | 2 +- dev/dev-poll.sh | 6 +++--- 4 files changed, 8 insertions(+), 8 deletions(-) diff --git a/action/action-agent.sh b/action/action-agent.sh index 1e3c877..a98ce0e 100755 --- a/action/action-agent.sh +++ b/action/action-agent.sh @@ -34,7 +34,7 @@ source "$(dirname "$0")/../lib/formula-session.sh" source "$(dirname "$0")/../dev/phase-handler.sh" SESSION_NAME="action-${ISSUE}" LOCKFILE="/tmp/action-agent-${ISSUE}.lock" -LOGFILE="${FACTORY_ROOT}/action/action-poll-${PROJECT_NAME:-harb}.log" +LOGFILE="${FACTORY_ROOT}/action/action-poll-${PROJECT_NAME:-default}.log" THREAD_FILE="/tmp/action-thread-${ISSUE}" IDLE_TIMEOUT="${ACTION_IDLE_TIMEOUT:-14400}" # 4h default MAX_LIFETIME="${ACTION_MAX_LIFETIME:-28800}" # 8h default wall-clock cap @@ -46,8 +46,8 @@ API="${CODEBERG_API}" BRANCH="action/issue-${ISSUE}" # shellcheck disable=SC2034 # used by phase-handler.sh WORKTREE="/tmp/action-${ISSUE}-$(date +%s)" -PHASE_FILE="/tmp/action-session-${PROJECT_NAME:-harb}-${ISSUE}.phase" -IMPL_SUMMARY_FILE="/tmp/action-impl-summary-${PROJECT_NAME:-harb}-${ISSUE}.txt" +PHASE_FILE="/tmp/action-session-${PROJECT_NAME:-default}-${ISSUE}.phase" +IMPL_SUMMARY_FILE="/tmp/action-impl-summary-${PROJECT_NAME:-default}-${ISSUE}.txt" PREFLIGHT_RESULT="/tmp/action-preflight-${ISSUE}.json" SCRATCH_FILE="/tmp/action-${ISSUE}-scratch.md" diff --git a/action/action-poll.sh b/action/action-poll.sh index 69fbe89..fafd737 100755 --- a/action/action-poll.sh +++ b/action/action-poll.sh @@ -14,7 +14,7 @@ set -euo pipefail export PROJECT_TOML="${1:-}" source "$(dirname "$0")/../lib/env.sh" -LOGFILE="${FACTORY_ROOT}/action/action-poll-${PROJECT_NAME:-harb}.log" +LOGFILE="${FACTORY_ROOT}/action/action-poll-${PROJECT_NAME:-default}.log" SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)" log() { diff --git a/dev/dev-agent.sh b/dev/dev-agent.sh index cc1eba5..07530b0 100755 --- a/dev/dev-agent.sh +++ b/dev/dev-agent.sh @@ -39,7 +39,7 @@ REPO="${CODEBERG_REPO}" REPO_ROOT="${PROJECT_REPO_ROOT}" API="${CODEBERG_API}" -LOCKFILE="/tmp/dev-agent-${PROJECT_NAME:-harb}.lock" +LOCKFILE="/tmp/dev-agent-${PROJECT_NAME:-default}.lock" STATUSFILE="/tmp/dev-agent-status" # Gitea labels API requires []int64 — look up the "backlog" label ID once diff --git a/dev/dev-poll.sh b/dev/dev-poll.sh index 09387a5..d84255d 100755 --- a/dev/dev-poll.sh +++ b/dev/dev-poll.sh @@ -26,7 +26,7 @@ UNDERSPECIFIED_LABEL_ID=$(codeberg_api GET "/labels" 2>/dev/null \ UNDERSPECIFIED_LABEL_ID="${UNDERSPECIFIED_LABEL_ID:-1300816}" # Track CI fix attempts per PR to avoid infinite respawn loops -CI_FIX_TRACKER="${FACTORY_ROOT}/dev/ci-fixes-${PROJECT_NAME:-harb}.json" +CI_FIX_TRACKER="${FACTORY_ROOT}/dev/ci-fixes-${PROJECT_NAME:-default}.json" CI_FIX_LOCK="${CI_FIX_TRACKER}.lock" ci_fix_count() { local pr="$1" @@ -211,8 +211,8 @@ try_direct_merge() { } API="${CODEBERG_API}" -LOCKFILE="/tmp/dev-agent-${PROJECT_NAME:-harb}.lock" -LOGFILE="${FACTORY_ROOT}/dev/dev-agent-${PROJECT_NAME:-harb}.log" +LOCKFILE="/tmp/dev-agent-${PROJECT_NAME:-default}.lock" +LOGFILE="${FACTORY_ROOT}/dev/dev-agent-${PROJECT_NAME:-default}.log" PREFLIGHT_RESULT="/tmp/dev-agent-preflight.json" SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"