johba/disinto
1
0
Fork 0
Code Issues 4 Pull requests Projects Releases Packages Wiki Activity Actions

fix: Duplicate read_phase definition in phase-test.sh (#179)

Browse source 
Source the canonical read_phase() from lib/agent-session.sh instead of
maintaining a local copy that could drift.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
openhands 2026-03-23 08:30:13 +00:00
parent a7cd2bbf5b
commit 13f62390a7
1 changed files with 4 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

11
dev/phase-test.sh
View file

@ -8,6 +8,9 @@
set -euo pipefail set -euo pipefail
# Source canonical read_phase() from shared library
source "$(dirname "$0")/../lib/agent-session.sh"
PROJECT="testproject" PROJECT="testproject"
ISSUE="999" ISSUE="999"
PHASE_FILE="/tmp/dev-session-${PROJECT}-${ISSUE}.phase" PHASE_FILE="/tmp/dev-session-${PROJECT}-${ISSUE}.phase"
@ -81,13 +84,7 @@ else
fail "PHASE:failed format: first='$first_line' second='$second_line'" fail "PHASE:failed format: first='$first_line' second='$second_line'"
fi fi
# ── Test 5: orchestrator read function ──────────────────────────────────────── # ── Test 5: orchestrator read function (canonical read_phase from lib/agent-session.sh)
read_phase() {
local pfile="$1"
# Allow cat to fail (missing file) — pipeline exits 0 via || true
{ cat "$pfile" 2>/dev/null || true; } | head -1 | tr -d '[:space:]'
}
echo "PHASE:awaiting_ci" > "$PHASE_FILE" echo "PHASE:awaiting_ci" > "$PHASE_FILE"
phase=$(read_phase "$PHASE_FILE") phase=$(read_phase "$PHASE_FILE")
if [ "$phase" = "PHASE:awaiting_ci" ]; then if [ "$phase" = "PHASE:awaiting_ci" ]; then