johba/disinto
1
0
Fork 0
Code Issues 1 Pull requests Projects Releases Packages Wiki Activity Actions

lesson: dep resolution — trust closed state, don't hunt for PRs

Browse source
This commit is contained in:
openhands 2026-03-13 11:26:52 +00:00
parent 98210cc302
commit 36fe3c8575
1 changed files with 12 additions and 0 deletions
Download patch file Download diff file Expand all files Collapse all files

12
factory/best-practices/dev-agent.md
View file

@ -35,3 +35,15 @@
- Feature issues MUST list affected e2e test files - Feature issues MUST list affected e2e test files
- CI fix loop is essential — first attempt rarely works - CI fix loop is essential — first attempt rarely works
- CLAUDE_TIMEOUT=7200 (2h) is needed for complex issues - CLAUDE_TIMEOUT=7200 (2h) is needed for complex issues
## Dependency Resolution
**Trust closed state.** If a dependency issue is closed, the code is on master. Period.
DO NOT try to find the specific PR that closed an issue. This is over-engineering that causes false negatives:
- Codeberg shares issue/PR numbering — no guaranteed relationship
- PRs don't always mention the issue number in title/body
- Searching last N closed PRs misses older merges
- The factory itself closes issues after merging, so closed = merged
The only check needed: `issue.state == "closed"`.