From 52f7c4973e5c2a2b015e1e7caee03a087954d79a Mon Sep 17 00:00:00 2001 From: openhands Date: Sat, 21 Mar 2026 00:39:58 +0000 Subject: [PATCH] =?UTF-8?q?fix:=20address=20review=20=E2=80=94=20phase=20s?= =?UTF-8?q?ignal=20quoting,=20issue=20count=20limits,=20reply=20comment?= MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit - Fix critical: use double quotes for $PHASE_FILE in formula phase signal - Fix low: use limit=50 for backlog/in-progress/blocked issue counts - Fix nit: correct misleading comment about escalation reply timing Co-Authored-By: Claude Opus 4.6 (1M context) --- formulas/run-supervisor.toml | 2 +- supervisor/preflight.sh | 8 ++++---- 2 files changed, 5 insertions(+), 5 deletions(-) diff --git a/formulas/run-supervisor.toml b/formulas/run-supervisor.toml index 033f4a1..da3fa82 100644 --- a/formulas/run-supervisor.toml +++ b/formulas/run-supervisor.toml @@ -232,6 +232,6 @@ IMPORTANT: Do NOT commit or push the journal — it is a local working file. The journal directory is committed to git periodically by other agents. After writing the journal, write the phase signal: - echo 'PHASE:done' > '$PHASE_FILE' + echo 'PHASE:done' > "$PHASE_FILE" """ needs = ["report"] diff --git a/supervisor/preflight.sh b/supervisor/preflight.sh index ee3f070..cab8543 100755 --- a/supervisor/preflight.sh +++ b/supervisor/preflight.sh @@ -139,9 +139,9 @@ echo "" # ── Backlog + In-Progress ───────────────────────────────────────────────── echo "## Issue Status (${PROJECT_NAME})" -_backlog_count=$(codeberg_api GET "/issues?state=open&labels=backlog&type=issues&limit=1" 2>/dev/null | jq 'length' 2>/dev/null || echo "?") -_in_progress_count=$(codeberg_api GET "/issues?state=open&labels=in-progress&type=issues&limit=1" 2>/dev/null | jq 'length' 2>/dev/null || echo "?") -_blocked_count=$(codeberg_api GET "/issues?state=open&labels=blocked&type=issues&limit=1" 2>/dev/null | jq 'length' 2>/dev/null || echo "?") +_backlog_count=$(codeberg_api GET "/issues?state=open&labels=backlog&type=issues&limit=50" 2>/dev/null | jq 'length' 2>/dev/null || echo "?") +_in_progress_count=$(codeberg_api GET "/issues?state=open&labels=in-progress&type=issues&limit=50" 2>/dev/null | jq 'length' 2>/dev/null || echo "?") +_blocked_count=$(codeberg_api GET "/issues?state=open&labels=blocked&type=issues&limit=50" 2>/dev/null | jq 'length' 2>/dev/null || echo "?") echo "Backlog: ${_backlog_count}, In-progress: ${_in_progress_count}, Blocked: ${_blocked_count}" echo "" @@ -181,7 +181,7 @@ echo "## Escalation Replies (from Matrix)" if [ -s /tmp/supervisor-escalation-reply ]; then cat /tmp/supervisor-escalation-reply echo "" - echo "(This reply will be consumed after this run)" + echo "(Reply already consumed by supervisor-run.sh before this session)" else echo " None" fi