feat: progressive disclosure + escalate everything to claude
- PROMPT.md references best-practices/ files instead of inlining all knowledge
- best-practices/{memory,disk,ci,dev-agent,git}.md — loaded on demand by claude
- All alerts go to claude -p. Claude decides what to fix and what to escalate.
- update-prompt.sh targets specific best-practices files for self-learning
This commit is contained in:
parent
cb7dd398c7
commit
5eb17020d5
8 changed files with 222 additions and 117 deletions
37
factory/best-practices/dev-agent.md
Normal file
37
factory/best-practices/dev-agent.md
Normal file
|
|
@ -0,0 +1,37 @@
|
|||
# Dev-Agent Best Practices
|
||||
|
||||
## Architecture
|
||||
- `dev-poll.sh` (cron */10) → finds ready backlog issues → spawns `dev-agent.sh`
|
||||
- `dev-agent.sh` uses `claude -p` for implementation, runs in git worktree
|
||||
- Lock file: `/tmp/dev-agent.lock` (contains PID)
|
||||
- Status file: `/tmp/dev-agent-status`
|
||||
- Worktrees: `/tmp/harb-worktree-<issue-number>/`
|
||||
|
||||
## Safe Fixes
|
||||
- Remove stale lock: `rm -f /tmp/dev-agent.lock` (only if PID is dead)
|
||||
- Kill stuck agent: `kill <pid>` then clean lock
|
||||
- Restart on derailed PR: `bash ${FACTORY_ROOT}/dev/dev-agent.sh <issue-number> &`
|
||||
- Clean worktree: `cd /home/debian/harb && git worktree remove /tmp/harb-worktree-<N> --force`
|
||||
- Remove `in-progress` label if agent died without cleanup:
|
||||
```bash
|
||||
codeberg_api DELETE "/issues/<N>/labels/in-progress"
|
||||
```
|
||||
|
||||
## Dangerous (escalate)
|
||||
- Restarting agent on an issue that has an open PR with review changes — may lose context
|
||||
- Anything that modifies the PR branch history
|
||||
- Closing PRs or issues
|
||||
|
||||
## Known Issues
|
||||
- `claude -p -c` (continue) fails if session was compacted — falls back to fresh `-p`
|
||||
- CI_FIX_COUNT is now reset on CI pass (fixed 2026-03-12), so each review phase gets fresh CI fix budget
|
||||
- Worktree creation fails if main repo has stale rebase — auto-heals now
|
||||
- Large text in jq `--arg` can break — write to file first
|
||||
- `$([ "$VAR" = true ] && echo "...")` crashes under `set -euo pipefail`
|
||||
|
||||
## Lessons Learned
|
||||
- Agents don't have memory between tasks — full context must be in the prompt
|
||||
- Prior art injection (closed PR diffs) prevents rework
|
||||
- Feature issues MUST list affected e2e test files
|
||||
- CI fix loop is essential — first attempt rarely works
|
||||
- CLAUDE_TIMEOUT=7200 (2h) is needed for complex issues
|
||||
Loading…
Add table
Add a link
Reference in a new issue