johba/disinto
1
0
Fork 0
Code Issues 4 Pull requests Projects Releases Packages Wiki Activity Actions

fix: write_state_entry defined after call site — crashes dev-agent

Browse source 
Function was defined at line 867 but called at line 550. Bash requires
functions to be defined before invocation. Moved to top with other
helpers. Also removed duplicate definition.
This commit is contained in:
openhands 2026-03-14 11:01:05 +00:00
parent c3f24460a7
commit 7fd913596b
1 changed files with 18 additions and 31 deletions
Download patch file Download diff file Expand all files Collapse all files

49
dev/dev-agent.sh
View file

@ -91,6 +91,24 @@ cleanup() {
}
trap cleanup EXIT
# STATE.MD helpers (must be defined before use at worktree setup)
write_state_entry() {
local status_word="${1:-in-progress}"
local target="${WORKTREE:-$REPO_ROOT}"
local state_file="${target}/STATE.md"
local today
today=$(date -u +%Y-%m-%d)
local description
description=$(echo "$ISSUE_TITLE" | sed 's/^feat:\s*//i;s/^fix:\s*//i;s/^refactor:\s*//i')
local line="- [${today}] [${status_word}] ${description} (#${ISSUE})"
if [ ! -f "$state_file" ]; then
printf '# STATE.md — What harb currently is and does\n\n' > "$state_file"
fi
echo "$line" >> "$state_file"
log "STATE.md: ${line}"
}
append_state_log() { write_state_entry "done"; }
# --- Log rotation ---
if [ -f "$LOGFILE" ] && [ "$(stat -c%s "$LOGFILE" 2>/dev/null || echo 0)" -gt 102400 ]; then
mv "$LOGFILE" "$LOGFILE.old"
@ -857,37 +875,6 @@ $(printf '%s' "$REFUSAL_JSON" | head -c 2000)
notify "PR #${PR_NUMBER} created for issue #${ISSUE}: ${ISSUE_TITLE}"
fi
# =============================================================================
# STATE.MD APPEND
# =============================================================================
# Write STATE.md entry in the worktree BEFORE implementation starts.
# This ensures the STATE.md update is part of the first commit, not a separate
# push that would dismiss stale approvals.
# Format: - [YYYY-MM-DD] <in-progress|done> description (#ISSUE)
write_state_entry() {
local status_word="${1:-in-progress}" # "in-progress" or "done"
local target="${WORKTREE:-$REPO_ROOT}"
local state_file="${target}/STATE.md"
local today
today=$(date -u +%Y-%m-%d)
local description
description=$(echo "$ISSUE_TITLE" | sed 's/^feat:\s*//i;s/^fix:\s*//i;s/^refactor:\s*//i')
local line="- [${today}] [${status_word}] ${description} (#${ISSUE})"
if [ ! -f "$state_file" ]; then
printf '# STATE.md — What harb currently is and does\n\n' > "$state_file"
fi
echo "$line" >> "$state_file"
log "STATE.md: ${line}"
}
# Alias for backward compat
append_state_log() {
write_state_entry "done"
}
# MERGE HELPER
# =============================================================================
do_merge() {