From e5965e71d46233cf37039624397d07b7968d1b83 Mon Sep 17 00:00:00 2001 From: openhands Date: Sat, 21 Mar 2026 00:05:09 +0000 Subject: [PATCH] fix: Stale REQUEST_CHANGES reviews still trigger re-work (#336) Co-Authored-By: Claude Opus 4.6 (1M context) --- dev/dev-poll.sh | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/dev/dev-poll.sh b/dev/dev-poll.sh index ec84acb..fa2f273 100755 --- a/dev/dev-poll.sh +++ b/dev/dev-poll.sh @@ -330,7 +330,7 @@ if [ "$ORPHAN_COUNT" -gt 0 ]; then HAS_APPROVE=$(echo "$REVIEWS_JSON" | \ jq -r '[.[] | select(.state == "APPROVED") | select(.stale == false)] | length') || true HAS_CHANGES=$(echo "$REVIEWS_JSON" | \ - jq -r '[.[] | select(.state == "REQUEST_CHANGES")] | length') || true + jq -r '[.[] | select(.state == "REQUEST_CHANGES") | select(.stale == false)] | length') || true if ci_passed "$CI_STATE" && [ "${HAS_APPROVE:-0}" -gt 0 ]; then if try_direct_merge "$HAS_PR" "$ISSUE_NUM"; then @@ -432,7 +432,7 @@ for i in $(seq 0 $(($(echo "$OPEN_PRS" | jq 'length') - 1))); do REVIEWS_JSON=$(curl -sf -H "Authorization: token ${CODEBERG_TOKEN}" \ "${API}/pulls/${PR_NUM}/reviews") || true HAS_CHANGES=$(echo "$REVIEWS_JSON" | \ - jq -r '[.[] | select(.state == "REQUEST_CHANGES")] | length') || true + jq -r '[.[] | select(.state == "REQUEST_CHANGES") | select(.stale == false)] | length') || true HAS_APPROVE=$(echo "$REVIEWS_JSON" | \ jq -r '[.[] | select(.state == "APPROVED") | select(.stale == false)] | length') || true @@ -542,7 +542,7 @@ for i in $(seq 0 $((BACKLOG_COUNT - 1))); do HAS_APPROVE=$(echo "$REVIEWS_JSON" | \ jq -r '[.[] | select(.state == "APPROVED") | select(.stale == false)] | length') || true HAS_CHANGES=$(echo "$REVIEWS_JSON" | \ - jq -r '[.[] | select(.state == "REQUEST_CHANGES")] | length') || true + jq -r '[.[] | select(.state == "REQUEST_CHANGES") | select(.stale == false)] | length') || true if ci_passed "$CI_STATE" && [ "${HAS_APPROVE:-0}" -gt 0 ]; then if try_direct_merge "$EXISTING_PR" "$ISSUE_NUM"; then