From 88eed09e7187733a952be509de53e5fbbb630526 Mon Sep 17 00:00:00 2001 From: openhands Date: Tue, 17 Mar 2026 16:52:49 +0000 Subject: [PATCH] fix: address review findings on formula templates and BOOTSTRAP docs - upgrade-dependency.toml: fix forge upgrade command (forge update, not forge install); remove redundant `npm install` after lockfile write; simplify description to "Upgrade {{package}} to {{to_version}}" so it reads cleanly when from_version is omitted - add-rpc-method.toml: remove dead `namespace` variable; inline namespace derivation logic into register-method step description - BOOTSTRAP.md: mark formula label entry as requiring feat/formula merge; add YAML front matter example so operators know the issue schema Co-Authored-By: Claude Sonnet 4.6 --- BOOTSTRAP.md | 2 +- formulas/add-rpc-method.toml | 10 +++------- formulas/upgrade-dependency.toml | 8 ++++---- 3 files changed, 8 insertions(+), 12 deletions(-) diff --git a/BOOTSTRAP.md b/BOOTSTRAP.md index 3d99306..80530a5 100644 --- a/BOOTSTRAP.md +++ b/BOOTSTRAP.md @@ -84,7 +84,7 @@ Optional but recommended: |-------|---------| | `tech-debt` | Gardener can promote these to `backlog` | | `blocked` | Dev-agent marks issues with unmet dependencies | -| `formula` | Dev-agent uses a structured TOML formula instead of freeform — issue body must have YAML front matter specifying the formula name and variables (see `formulas/`) | +| `formula` | *(requires `feat/formula` merge)* Dev-agent uses a structured TOML formula instead of freeform. Issue body must include YAML front matter, e.g.:
`---`
`formula: upgrade-dependency`
`vars:`
` package: viem`
` ecosystem: npm`
`---` | ### Required: Branch protection diff --git a/formulas/add-rpc-method.toml b/formulas/add-rpc-method.toml index 9f60904..f11e1f4 100644 --- a/formulas/add-rpc-method.toml +++ b/formulas/add-rpc-method.toml @@ -18,11 +18,6 @@ description = "Return type description (e.g. 'U256 balance', 'Vec')" required = false default = "result" -[vars.namespace] -description = "RPC namespace prefix (e.g. eth, harb, net) — derived from method_name if omitted" -required = false -default = "" - [[steps]] id = "read-existing" title = "Read existing RPC methods for patterns" @@ -61,8 +56,9 @@ description = """ Add {{method_name}} to the server's method registry / router, following the same registration pattern used by existing methods. -Verify the method is reachable — check that no namespace filter or -allowlist would block it in the default configuration. +The namespace is the prefix of {{method_name}} before the underscore +(e.g. "eth" for "eth_getBalance"). Verify the server's namespace filter or +allowlist includes this namespace in the default configuration. """ needs = ["implement-handler"] diff --git a/formulas/upgrade-dependency.toml b/formulas/upgrade-dependency.toml index 0f81562..76686c8 100644 --- a/formulas/upgrade-dependency.toml +++ b/formulas/upgrade-dependency.toml @@ -1,7 +1,7 @@ # formulas/upgrade-dependency.toml — Upgrade a package dependency name = "upgrade-dependency" -description = "Upgrade {{package}} from {{from_version}} to {{to_version}}" +description = "Upgrade {{package}} to {{to_version}}" version = 1 [vars.package] @@ -38,11 +38,11 @@ description = """ Run the appropriate upgrade command for ecosystem={{ecosystem}}: - npm: npm install {{package}}@{{to_version}} (or @latest) - Then: npm install (to sync lockfile) - cargo: cargo update -p {{package}} [--precise {{to_version}}] Or bump version in Cargo.toml, then: cargo build -- forge: Update version in foundry.toml or gitmodules, then: - forge install {{package}} (or forge update {{package}}) +- forge: forge update {{package}} + (Use forge install only if reinstalling from scratch after manually + editing the commit hash in .gitmodules or lib/) Confirm the lockfile / manifest now reflects {{to_version}}. """