From 946921431cbbc52c4943a499da0760718a4fdeb0 Mon Sep 17 00:00:00 2001
From: openhands <openhands@all-hands.dev>
Date: Thu, 26 Mar 2026 12:47:18 +0000
Subject: [PATCH] =?UTF-8?q?fix:=20address=20review=20=E2=80=94=20error=20f?=
 =?UTF-8?q?allback,=20schema=20consistency,=20line-level=20recovery=20(#71?=
 =?UTF-8?q?8)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

- Add jq error fallback to TOP_PAGES pipeline (matches TOP_REFERRERS guard)
- Add referred_visitors and response_time to empty-period report schema
- Switch Caddy log parsing to jq -R with try/fromjson for line-level recovery

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
---
 site/collect-engagement.sh | 9 ++++++---
 1 file changed, 6 insertions(+), 3 deletions(-)

diff --git a/site/collect-engagement.sh b/site/collect-engagement.sh
index c5975c6..38e3d5f 100644
--- a/site/collect-engagement.sh
+++ b/site/collect-engagement.sh
@@ -69,8 +69,9 @@ log "Parsing ${CADDY_LOG} for entries since $(date -u -d "@${CUTOFF_TS}" +%Y-%m-
 #   request.headers.User-Agent, status, size, duration
 #
 # Filter to last 24h, exclude assets/bots, produce a clean JSONL stream.
-PARSED=$(jq -c --argjson cutoff "$CUTOFF_TS" '
-  select(.ts >= $cutoff)
+PARSED=$(jq -Rc --argjson cutoff "$CUTOFF_TS" '
+  try fromjson
+  | select(.ts >= $cutoff)
   | select(.request.uri != null)
   | {
       ts: .ts,
@@ -99,8 +100,10 @@ if [ -z "$PARSED" ]; then
       total_requests: 0,
       unique_visitors: 0,
       page_views: 0,
+      referred_visitors: 0,
       top_pages: [],
       top_referrers: [],
+      response_time: { p50_seconds: 0, p95_seconds: 0, p99_seconds: 0 },
       note: "no entries in period"
     }' > "${EVIDENCE_DIR}/${REPORT_DATE}.json"
   log "Empty report written to ${EVIDENCE_DIR}/${REPORT_DATE}.json"
@@ -126,7 +129,7 @@ UNIQUE_VISITORS=$(printf '%s\n' "$PAGES" | jq -r '.ip' | sort -u | wc -l | tr -d
 TOP_PAGES=$(printf '%s\n' "$PAGES" | jq -r '.uri' \
   | sort | uniq -c | sort -rn | head -10 \
   | awk '{printf "{\"path\":\"%s\",\"views\":%d}\n", $2, $1}' \
-  | jq -sc '.')
+  | jq -sc '.' 2>/dev/null || echo '[]')
 
 # Top referrers (exclude direct/self)
 TOP_REFERRERS=$(printf '%s\n' "$PAGES" | jq -r '.referer' \