johba/disinto
1
0
Fork 0
Code Issues 4 Pull requests Projects Releases Packages Wiki Activity Actions

fix: use _found_stale flag matching established preflight pattern (#664)

Browse source 
Rename _cleaned_any to _found_stale and set it on any match (not just
deletion), so "None" only prints when no stale files exist. Prevents
contradictory output when grace-period entries are present.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
This commit is contained in:
openhands 2026-03-25 09:00:33 +00:00
parent b60811f0a1
commit af0795da88
1 changed files with 3 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

8
supervisor/preflight.sh
View file

@ -73,7 +73,7 @@ echo ""
# Grace period: 24h after issue closure to avoid race conditions. # Grace period: 24h after issue closure to avoid race conditions.
echo "## Stale Phase Cleanup" echo "## Stale Phase Cleanup"
_cleaned_any=false _found_stale=false
for _pf in /tmp/*-session-*.phase; do for _pf in /tmp/*-session-*.phase; do
[ -f "$_pf" ] || continue [ -f "$_pf" ] || continue
_phase_line=$(head -1 "$_pf" 2>/dev/null || echo "") _phase_line=$(head -1 "$_pf" 2>/dev/null || echo "")
@ -94,6 +94,7 @@ for _pf in /tmp/*-session-*.phase; do
[ -n "$_issue_json" ] || continue [ -n "$_issue_json" ] || continue
_state=$(printf '%s' "$_issue_json" | jq -r '.state // empty' 2>/dev/null) _state=$(printf '%s' "$_issue_json" | jq -r '.state // empty' 2>/dev/null)
[ "$_state" = "closed" ] || continue [ "$_state" = "closed" ] || continue
_found_stale=true
# Enforce 24h grace period after closure # Enforce 24h grace period after closure
_closed_at=$(printf '%s' "$_issue_json" | jq -r '.closed_at // empty' 2>/dev/null) _closed_at=$(printf '%s' "$_issue_json" | jq -r '.closed_at // empty' 2>/dev/null)
[ -n "$_closed_at" ] || continue [ -n "$_closed_at" ] || continue
@ -103,15 +104,12 @@ for _pf in /tmp/*-session-*.phase; do
if [ "$_elapsed" -gt 86400 ]; then if [ "$_elapsed" -gt 86400 ]; then
rm -f "$_pf" rm -f "$_pf"
echo " Cleaned: $(basename "$_pf") — issue #${_issue_num} closed at ${_closed_at}" echo " Cleaned: $(basename "$_pf") — issue #${_issue_num} closed at ${_closed_at}"
_cleaned_any=true
else else
_remaining_h=$(( (86400 - _elapsed) / 3600 )) _remaining_h=$(( (86400 - _elapsed) / 3600 ))
echo " Grace: $(basename "$_pf") — issue #${_issue_num} closed, ${_remaining_h}h remaining" echo " Grace: $(basename "$_pf") — issue #${_issue_num} closed, ${_remaining_h}h remaining"
fi fi
done done
if [ "$_cleaned_any" = false ]; then [ "$_found_stale" = false ] && echo " None"
echo " None"
fi
echo "" echo ""
# ── Lock Files ──────────────────────────────────────────────────────────── # ── Lock Files ────────────────────────────────────────────────────────────