fix: shellcheck TODO has no enforcement — || true may never be removed (#71)

- Fix SC2164: add || exit 1 to bare cd in update-prompt.sh
- Fix SC2155: separate declare and assign in env.sh, supervisor-poll.sh, dev-agent.sh
- Fix SC2034: inline suppression for vars used by sourced helpers
- Remove unused `mergeable` declaration, rename unused loop var to `_w`
- Remove || true from shellcheck CI step — failures are now blocking

Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>

dev/dev-agent.sh

@@ -28,7 +28,9 @@ git -C "$FACTORY_ROOT" pull --ff-only origin main 2>/dev/null || true
 
 # --- Config ---
 ISSUE="${1:?Usage: dev-agent.sh <issue-number>}"
+# shellcheck disable=SC2034
 REPO="${CODEBERG_REPO}"
+# shellcheck disable=SC2034
 REPO_ROOT="${PROJECT_REPO_ROOT}"
 
 API="${CODEBERG_API}"
@@ -143,7 +145,8 @@ post_refusal_comment() {
     log "skipping duplicate refusal comment: ${title}"
     return 0
   fi
-  local comment="${emoji} **Dev-agent: ${title}**
+  local comment
+  comment="${emoji} **Dev-agent: ${title}**
 
 ${body}
 

dev/dev-poll.sh

@@ -83,6 +83,7 @@ sys.exit(1)
 " 2>/dev/null && return 0 || return 1
 }
 
+# shellcheck disable=SC2034
 REPO="${CODEBERG_REPO}"
 
 API="${CODEBERG_API}"
@@ -98,7 +99,7 @@ log() {
 # HELPER: try merge, rebase if mergeable=false, then retry once
 try_merge_or_rebase() {
   local pr_num="$1" issue_num="$2" branch="$3"
-  local merge_code mergeable
+  local merge_code
 
   merge_code=$(curl -s -o /dev/null -w "%{http_code}" -X POST \
     -H "Authorization: token ${CODEBERG_TOKEN}" \
@@ -472,7 +473,7 @@ nohup "${SCRIPT_DIR}/dev-agent.sh" "$READY_ISSUE" >> "$LOGFILE" 2>&1 &
 AGENT_PID=$!
 
 # Wait briefly for preflight (agent writes result before claiming)
-for w in $(seq 1 30); do
+for _w in $(seq 1 30); do
   if [ -f "$PREFLIGHT_RESULT" ]; then
     break
   fi