fix: shellcheck TODO has no enforcement — || true may never be removed (#71)
- Fix SC2164: add || exit 1 to bare cd in update-prompt.sh - Fix SC2155: separate declare and assign in env.sh, supervisor-poll.sh, dev-agent.sh - Fix SC2034: inline suppression for vars used by sourced helpers - Remove unused `mergeable` declaration, rename unused loop var to `_w` - Remove || true from shellcheck CI step — failures are now blocking Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This commit is contained in:
parent
81e5e5aa50
commit
bd02330b22
9 changed files with 20 additions and 9 deletions
|
|
@ -511,6 +511,7 @@ check_project() {
|
|||
BODY=$(echo "$BACKLOG_FOR_DEPS" | jq -r ".[$i].body // \"\"")
|
||||
ISSUE_DEPS=$(echo "$BODY" | bash "$PARSE_DEPS" | grep -v "^${NUM}$" || true)
|
||||
[ -n "$ISSUE_DEPS" ] && DEPS_OF[$NUM]="$ISSUE_DEPS"
|
||||
# shellcheck disable=SC2034
|
||||
BACKLOG_NUMS[$NUM]=1
|
||||
done
|
||||
|
||||
|
|
@ -526,7 +527,8 @@ check_project() {
|
|||
for dep in ${DEPS_OF[$node]:-}; do
|
||||
[ -z "${NODE_COLOR[$dep]+x}" ] && continue
|
||||
if [ "${NODE_COLOR[$dep]}" = "1" ]; then
|
||||
local cycle_key=$(echo "$path $dep" | tr ' ' '\n' | sort -n | tr '\n' ' ')
|
||||
local cycle_key
|
||||
cycle_key=$(echo "$path $dep" | tr ' ' '\n' | sort -n | tr '\n' ' ')
|
||||
if [ -z "${SEEN_CYCLES[$cycle_key]+x}" ]; then
|
||||
SEEN_CYCLES[$cycle_key]=1
|
||||
local in_cycle=0 cycle_str=""
|
||||
|
|
|
|||
Loading…
Add table
Add a link
Reference in a new issue