From 9fa4846581ef6850bc903b9cc5a69ebbe3e9d3f2 Mon Sep 17 00:00:00 2001
From: openhands <openhands@all-hands.dev>
Date: Wed, 18 Mar 2026 08:13:43 +0000
Subject: [PATCH 1/2] =?UTF-8?q?fix:=20ALL=5FCOMMENTS=20fetch=20is=20capped?=
 =?UTF-8?q?=20at=20limit=3D50=20=E2=80=94=20watermark=20search=20may=20mis?=
 =?UTF-8?q?s=20reviews=20on=20high-comment=20PRs=20(#100)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 dev/dev-agent.sh      |  3 +--
 lib/env.sh            | 22 ++++++++++++++++++++++
 review/review-poll.sh |  3 +--
 review/review-pr.sh   |  6 ++----
 4 files changed, 26 insertions(+), 8 deletions(-)

diff --git a/dev/dev-agent.sh b/dev/dev-agent.sh
index 0e43171..21eba37 100755
--- a/dev/dev-agent.sh
+++ b/dev/dev-agent.sh
@@ -1244,8 +1244,7 @@ Instructions:
 
       REVIEW_SHA=$(curl -sf -H "Authorization: token ${CODEBERG_TOKEN}" \
         "${API}/pulls/${PR_NUMBER}" | jq -r '.head.sha') || true
-      REVIEW_COMMENT=$(curl -sf -H "Authorization: token ${CODEBERG_TOKEN}" \
-        "${API}/issues/${PR_NUMBER}/comments?limit=50" | \
+      REVIEW_COMMENT=$(codeberg_api_all "/issues/${PR_NUMBER}/comments" | \
         jq -r --arg sha "$REVIEW_SHA" \
         '[.[] | select(.body | contains("<!-- reviewed: " + $sha))] | last // empty') || true
 
diff --git a/lib/env.sh b/lib/env.sh
index 90c5bf5..38a4820 100755
--- a/lib/env.sh
+++ b/lib/env.sh
@@ -56,6 +56,28 @@ codeberg_api() {
     "${CODEBERG_API}${path}" "$@"
 }
 
+# Paginate a Codeberg API GET endpoint and return all items as a merged JSON array.
+# Usage: codeberg_api_all /path             (no existing query params)
+#        codeberg_api_all /path?a=b         (with existing params — appends &limit=50&page=N)
+codeberg_api_all() {
+  local path_prefix="$1"
+  local sep page page_items count all_items="[]"
+  case "$path_prefix" in
+    *"?"*) sep="&" ;;
+    *) sep="?" ;;
+  esac
+  page=1
+  while true; do
+    page_items=$(codeberg_api GET "${path_prefix}${sep}limit=50&page=${page}") || break
+    count=$(printf '%s' "$page_items" | jq 'length')
+    [ "$count" -eq 0 ] && break
+    all_items=$(printf '%s\n%s' "$all_items" "$page_items" | jq -s 'add')
+    [ "$count" -lt 50 ] && break
+    page=$((page + 1))
+  done
+  printf '%s' "$all_items"
+}
+
 # Woodpecker API helper
 woodpecker_api() {
   local path="$1"
diff --git a/review/review-poll.sh b/review/review-poll.sh
index 128e885..799cc14 100755
--- a/review/review-poll.sh
+++ b/review/review-poll.sh
@@ -112,8 +112,7 @@ inject_review_into_dev_session() {
   [ "${current_phase}" = "PHASE:awaiting_review" ] || return 0
 
   local review_comment
-  review_comment=$(curl -sf -H "Authorization: token ${CODEBERG_TOKEN}" \
-    "${API_BASE}/issues/${pr_num}/comments?limit=50" | \
+  review_comment=$(codeberg_api_all "/issues/${pr_num}/comments" | \
     jq -r --arg sha "${pr_sha}" \
     '[.[] | select(.body | contains("<!-- reviewed: " + $sha))] | last // empty') || true
   if [ -z "${review_comment}" ] || [ "${review_comment}" = "null" ]; then
diff --git a/review/review-pr.sh b/review/review-pr.sh
index 35d7a7e..c332057 100755
--- a/review/review-pr.sh
+++ b/review/review-pr.sh
@@ -187,8 +187,7 @@ fi
 
 # --- Check for existing reviews ---
 status "checking existing reviews"
-ALL_COMMENTS=$(curl -sf -H "Authorization: token ${CODEBERG_TOKEN}" \
-  "${API_BASE}/issues/${PR_NUMBER}/comments?limit=50")
+ALL_COMMENTS=$(codeberg_api_all "/issues/${PR_NUMBER}/comments")
 
 # Check review-comment watermarks — skip if a comment with <!-- reviewed: SHA --> exists
 COMMENT_REVIEWED=$(echo "$ALL_COMMENTS" | \
@@ -797,8 +796,7 @@ if [ "$FOLLOWUP_COUNT" -gt 0 ]; then
     FU_DETAILS=$(printf '%s' "$fu" | jq -r '.details')
 
     # Check for duplicate
-    EXISTING=$(curl -sf -H "Authorization: token ${CODEBERG_TOKEN}" \
-      "${API_BASE}/issues?state=open&labels=tech-debt&limit=50" | \
+    EXISTING=$(codeberg_api_all "/issues?state=open&labels=tech-debt" | \
       jq -r --arg t "$FU_TITLE" '[.[] | select(.title == $t)] | length')
 
     if [ "${EXISTING:-0}" -gt 0 ]; then

From d5b3f9e6e58340b05fb765049f433e8cd752eb57 Mon Sep 17 00:00:00 2001
From: openhands <openhands@all-hands.dev>
Date: Wed, 18 Mar 2026 08:25:22 +0000
Subject: [PATCH 2/2] fix: codeberg_api_all propagates API errors instead of
 silently returning []
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

Remove || break from the codeberg_api call in the pagination loop.
With set -euo pipefail in all callers, a failed fetch now exits the
function non-zero — matching the original curl -sf behaviour where a
network or auth error aborted the script rather than returning empty
results and risking a duplicate review.

Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
---
 lib/env.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/lib/env.sh b/lib/env.sh
index 38a4820..85e28bf 100755
--- a/lib/env.sh
+++ b/lib/env.sh
@@ -68,7 +68,7 @@ codeberg_api_all() {
   esac
   page=1
   while true; do
-    page_items=$(codeberg_api GET "${path_prefix}${sep}limit=50&page=${page}") || break
+    page_items=$(codeberg_api GET "${path_prefix}${sep}limit=50&page=${page}")
     count=$(printf '%s' "$page_items" | jq 'length')
     [ "$count" -eq 0 ] && break
     all_items=$(printf '%s\n%s' "$all_items" "$page_items" | jq -s 'add')