johba/disinto
1
0
Fork 0
Code Issues 5 Pull requests 1 Projects Releases Packages Wiki Activity Actions

fix: review-poll.sh still uses tmux for session cleanup and injection #11

New issue
Closed
opened 2026-03-28 10:59:29 +00:00 by dev-bot · 0 comments
dev-bot commented 2026-03-28 10:59:29 +00:00
Collaborator
Copy link

Problem

review-pr.sh was migrated to SDK (agent_run --resume + .sid files), but review-poll.sh still references tmux sessions for:

  1. Stale session cleanup (lines 43-82): tmux list-sessions, tmux kill-session — these find nothing since review-pr.sh no longer creates tmux sessions. Dead code.
  2. Incremental diff injection (lines 179-186): tmux paste-buffer, tmux send-keys — attempts to inject new diffs into a running tmux session that doesn't exist. Non-functional.

The code doesn't crash (all tmux calls are guarded with || true), but stale sessions are never cleaned up via the new mechanism (.sid files, worktrees).

Mirrors codeberg.org/johba/disinto#777 (persistent reviewer sessions — core feature is done, this is the cleanup).

Fix

  • Replace tmux session cleanup with .sid file + worktree cleanup
  • Remove tmux injection path (re-review is now handled by review-pr.sh itself via --resume)
  • Clean up stale .sid files and review worktrees for merged/closed PRs

Affected files

  • review/review-poll.sh
## Problem `review-pr.sh` was migrated to SDK (`agent_run --resume` + `.sid` files), but `review-poll.sh` still references tmux sessions for: 1. **Stale session cleanup** (lines 43-82): `tmux list-sessions`, `tmux kill-session` — these find nothing since review-pr.sh no longer creates tmux sessions. Dead code. 2. **Incremental diff injection** (lines 179-186): `tmux paste-buffer`, `tmux send-keys` — attempts to inject new diffs into a running tmux session that doesn't exist. Non-functional. The code doesn't crash (all tmux calls are guarded with `|| true`), but stale sessions are never cleaned up via the new mechanism (`.sid` files, worktrees). Mirrors codeberg.org/johba/disinto#777 (persistent reviewer sessions — core feature is done, this is the cleanup). ## Fix - Replace tmux session cleanup with `.sid` file + worktree cleanup - Remove tmux injection path (re-review is now handled by `review-pr.sh` itself via `--resume`) - Clean up stale `.sid` files and review worktrees for merged/closed PRs ## Affected files - `review/review-poll.sh`
dev-bot added the
backlog
 label 2026-03-28 10:59:29 +00:00
dev-bot added
in-progress
 and removed
backlog
 labels 2026-03-28 14:01:38 +00:00
Sign in to join this conversation.
No Branch/Tag specified
Branches Tags
main
fix/issue-123
fix/issue-14
fix/issue-21
v0.1.0
Labels
Clear labels   
action

   
backlog

   
blocked

   
in-progress

   
priority

   
tech-debt

   
underspecified

   
vision
No labels
action
backlog
blocked
in-progress
priority
tech-debt
underspecified
vision
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference: johba/disinto#11
No description provided.
Delete branch "%!s()"

Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?