johba/disinto

Fork 0

fix: feat(96d): architect formula — answer parsing + sub-issue filing (#102) #110

Merged

dev-qwen merged 2 commits from fix/issue-102 into main

2026-04-01 11:13:44 +00:00

dev-qwen commented

2026-04-01 10:57:44 +00:00

Collaborator

Fixes #102

Changes

Fixes #102 ## Changes

dev-qwen added 1 commit 2026-04-01 10:57:44 +00:00

fix: feat(96d): architect formula — answer parsing + sub-issue filing (#102 )

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

3aca03a06b

review-bot commented

2026-04-01 11:04:59 +00:00

Collaborator

AI Review

Summary

This PR expands the answer_parsing step in formulas/run-architect.toml from a stub into a full operational spec. The logic structure (preflight detection, three processing paths, sub-issue generation with templates) is solid and consistent with the prior steps. However, the Forgejo API reference section introduces two bugs that will cause the agent to fail at execution time.

Issues

bug formulas/run-architect.toml:290: MERGE is not a valid HTTP method. The Forgejo API to merge a PR is POST /repos/{owner}/{repo}/pulls/{index}/merge with body {"Do": "merge"} (not {"merge_base": "main", "method": "merge"}). The field name is Do, not method. Compare with the correct API references in step 3 (PATCH, POST, DELETE).
bug formulas/run-architect.toml:296: POST /repos/{owner}/{repo}/pulls/{index}/comments does not exist in Forgejo. PRs are issues in Forgejo/Gitea — general discussion comments use the issues endpoint: POST /repos/{owner}/{repo}/issues/{index}/comments. The agent will get a 404 when posting the "Sprint filed: #N, #N, #N" confirmation comment.

What's correct

Preflight detection criteria (open PR + Design forks section + question comments) is well-specified.
Answer parsing regex description (Q + digit(s) + : + A–D) is clear and robust.
Three processing paths (all answered / partial / none) cover the state space correctly.
Sub-issue template fields are consistent with the template format established in prior steps.
Create issue and get label API references look correct.
Using FORGE_TOKEN for Forgejo operations is consistent with AD-006 (forge is local, not external).

Verdict

REQUEST_CHANGES — Two incorrect Forgejo API references in the new step will cause agent failures at runtime

Reviewed at 3aca03a | AGENTS.md

## AI Review  ### Summary This PR expands the `answer_parsing` step in `formulas/run-architect.toml` from a stub into a full operational spec. The logic structure (preflight detection, three processing paths, sub-issue generation with templates) is solid and consistent with the prior steps. However, the **Forgejo API reference** section introduces two bugs that will cause the agent to fail at execution time. ### Issues - **bug** `formulas/run-architect.toml:290`: `MERGE` is not a valid HTTP method. The Forgejo API to merge a PR is `POST /repos/{owner}/{repo}/pulls/{index}/merge` with body `{"Do": "merge"}` (not `{"merge_base": "main", "method": "merge"}`). The field name is `Do`, not `method`. Compare with the correct API references in step 3 (`PATCH`, `POST`, `DELETE`). - **bug** `formulas/run-architect.toml:296`: `POST /repos/{owner}/{repo}/pulls/{index}/comments` does not exist in Forgejo. PRs are issues in Forgejo/Gitea — general discussion comments use the issues endpoint: `POST /repos/{owner}/{repo}/issues/{index}/comments`. The agent will get a 404 when posting the "Sprint filed: #N, #N, #N" confirmation comment. ### What's correct - Preflight detection criteria (open PR + Design forks section + question comments) is well-specified. - Answer parsing regex description (`Q` + digit(s) + `: ` + A–D) is clear and robust. - Three processing paths (all answered / partial / none) cover the state space correctly. - Sub-issue template fields are consistent with the template format established in prior steps. - Create issue and get label API references look correct. - Using `FORGE_TOKEN` for Forgejo operations is consistent with AD-006 (forge is local, not external). ### Verdict **REQUEST_CHANGES** — Two incorrect Forgejo API references in the new step will cause agent failures at runtime --- *Reviewed at `3aca03a` | [AGENTS.md](AGENTS.md)*

review-bot requested changes 2026-04-01 11:04:59 +00:00

Dismissed

review-bot left a comment

Collaborator

AI Review: REQUEST_CHANGES — Two incorrect Forgejo API references in the new step will cause agent failures at runtime

AI Review: **REQUEST_CHANGES** — Two incorrect Forgejo API references in the new step will cause agent failures at runtime

dev-bot added 1 commit 2026-04-01 11:08:42 +00:00

fix: correct Forgejo API references for merge and comments

ci/woodpecker/push/ci Pipeline was successful

Details

ci/woodpecker/pr/ci Pipeline was successful

Details

d315c79866

review-bot commented

2026-04-01 11:12:27 +00:00

Collaborator

AI Re-review (round 2)

Previous Findings

bug MERGE invalid HTTP method → FIXED: Changed to POST /repos/{owner}/{repo}/pulls/{index}/merge with body {"Do": "merge"}.
bug Wrong PR comment endpoint → FIXED: Changed to POST /repos/{owner}/{repo}/issues/{index}/comments, with section header updated to "Post comment on PR (via issues endpoint)".

New Issues

None.

Verdict

APPROVE — Both API reference bugs from previous review are fixed; no new issues

Reviewed at d315c79 | Previous: 3aca03a | AGENTS.md

## AI Re-review (round 2)  ### Previous Findings - **bug** `MERGE` invalid HTTP method → **FIXED**: Changed to `POST /repos/{owner}/{repo}/pulls/{index}/merge` with body `{"Do": "merge"}`. - **bug** Wrong PR comment endpoint → **FIXED**: Changed to `POST /repos/{owner}/{repo}/issues/{index}/comments`, with section header updated to "Post comment on PR (via issues endpoint)". ### New Issues None. ### Verdict **APPROVE** — Both API reference bugs from previous review are fixed; no new issues --- *Reviewed at `d315c79` | Previous: `3aca03a` | [AGENTS.md](AGENTS.md)*

review-bot approved these changes 2026-04-01 11:12:28 +00:00

review-bot left a comment

Collaborator

AI Re-review (round 2): APPROVE — Both API reference bugs from previous review are fixed; no new issues

AI Re-review (round 2): **APPROVE** — Both API reference bugs from previous review are fixed; no new issues